run-make: audit tests that codegen for specific targets #129390
Assignees
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rustbot
added
the
needs-triage
jieyouxu
added
A-run-make
|
E.g. for rust/src/tools/tidy/src/target_specific_tests.rs Lines 13 to 31 in 0f6e1ae Between this directive and |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Aug 31, 2024
…Mark-Simulacrum Add missing `needs-llvm-components` directives for run-make tests that need target-specific codegen Without suitable `needs-llvm-components` directives, some run-make tests exercising target-specific codegen can fail if the LLVM used is built without the necessary components. Currently, the list is: ``` tests\run-make\print-target-list tests\run-make\print-to-output tests\run-make\print-cfg tests\run-make\target-without-atomic-cas ``` This PR also skips tidy checks for revisions and `needs-llvm-components` for run-make tests since revisions are not supported. Fixes rust-lang#129390. Fixes rust-lang#127895. cc `@petrochenkov` who noticed this, thanks! Would be great if you could confirm that this fixes the test errors for you locally.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Aug 31, 2024
Rollup merge of rust-lang#129605 - jieyouxu:needs-llvm-components, r=Mark-Simulacrum Add missing `needs-llvm-components` directives for run-make tests that need target-specific codegen Without suitable `needs-llvm-components` directives, some run-make tests exercising target-specific codegen can fail if the LLVM used is built without the necessary components. Currently, the list is: ``` tests\run-make\print-target-list tests\run-make\print-to-output tests\run-make\print-cfg tests\run-make\target-without-atomic-cas ``` This PR also skips tidy checks for revisions and `needs-llvm-components` for run-make tests since revisions are not supported. Fixes rust-lang#129390. Fixes rust-lang#127895. cc ``@petrochenkov`` who noticed this, thanks! Would be great if you could confirm that this fixes the test errors for you locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tests doing codegen for specific targets need
//@ needs-llvm-componentsdirectives.These are the tests that are currently missing the directives and failing if LLVM is built without various aarch64/arm/thumb components or wasm.
Originally posted by @petrochenkov in #121876 (comment)
The text was updated successfully, but these errors were encountered: