Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./x.py test compiler/rustc_abi no longer works #129727

Closed
Veykril opened this issue Aug 29, 2024 · 5 comments · Fixed by #129781
Closed

./x.py test compiler/rustc_abi no longer works #129727

Veykril opened this issue Aug 29, 2024 · 5 comments · Fixed by #129781
Assignees
@Veykril
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Veykril
Copy link
Member

Veykril commented Aug 29, 2024 •
edited by rustbot
Loading

This regressed with #128722
Running ./x.py test compiler/rustc_abi (as well as for most other compiler crates) no longer works, resulting in an error similar to the following:

error: none of the selected packages contains these features: jemalloc, llvm, max_level_info, rustc_use_parallel_compiler
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 29, 2024
@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 29, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 29, 2024
@onur-ozkan onur-ozkan mentioned this issue Aug 29, 2024
Merged
@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

@rustbot claim

@Veykril
Copy link
Member Author

Veykril commented Aug 29, 2024

Fixing this will be troublesome https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60parallel_compiler.60.20or.20.60rustc_use_parallel_compiler.60

This was referenced Aug 30, 2024
Open
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 6, 2024
@workingjubilee
Rollup merge of rust-lang#129781 - Veykril:lw-x-py-compiler-features,…
bf5f35f 
… r=albertlarsan68

Make `./x.py <cmd> compiler/<crate>` aware of the crate's features

Does not fix rust-lang#129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with `resolver = 2` but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 6, 2024
@workingjubilee
Rollup merge of rust-lang#129781 - Veykril:lw-x-py-compiler-features,…
0c5c4a7 
… r=albertlarsan68

Make `./x.py <cmd> compiler/<crate>` aware of the crate's features

Does not fix rust-lang#129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with `resolver = 2` but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).
@bors bors closed this as completed in b09f316 Sep 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 6, 2024
@rust-timer
Unrolled build for rust-lang#129781
51c5006 
Rollup merge of rust-lang#129781 - Veykril:lw-x-py-compiler-features, r=albertlarsan68

Make `./x.py <cmd> compiler/<crate>` aware of the crate's features

Does not fix rust-lang#129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with `resolver = 2` but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).
@Veykril
Copy link
Member Author

Veykril commented Sep 6, 2024

Whoops, I did not mean to close this with that PR (and I can't reopen it for some reason) this is still an issue

@Veykril Veykril mentioned this issue Sep 6, 2024
Closed
@onur-ozkan onur-ozkan reopened this Sep 6, 2024
@GrigorenkoPV
Copy link
Contributor

#131093 may be a duplicate of this

@Veykril
Copy link
Member Author

Veykril commented Dec 12, 2024

#132282 removed all of the problematic cfgs/features so this now works again 🎉

@Veykril Veykril closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ./x.py <cmd> compiler/<crate> aware of the crate's features Veykril/rust
5 participants
@Veykril @jieyouxu @onur-ozkan @rustbot @GrigorenkoPV