Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for const_str_as_mut #130086

Closed
1 of 3 tasks
RalfJung opened this issue Sep 7, 2024 · 4 comments · Fixed by #131177
Closed
1 of 3 tasks

Tracking Issue for const_str_as_mut #130086

RalfJung opened this issue Sep 7, 2024 · 4 comments · Fixed by #131177
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Sep 7, 2024

Feature gate: #![feature(const_str_as_mut)]

This is a tracking issue for const mutable str accessors:

impl str {
    pub const unsafe fn as_bytes_mut(&mut self) -> &mut [u8];
    pub const fn as_mut_ptr(&mut self) -> *mut u8;
}

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html

@RalfJung RalfJung added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Sep 7, 2024
@dtolnay
Copy link
Member

dtolnay commented Sep 7, 2024

@rfcbot fcp merge

const for these already-stable functions:

@rfcbot
Copy link

rfcbot commented Sep 7, 2024

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 7, 2024
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 24, 2024
@rfcbot
Copy link

rfcbot commented Sep 24, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 4, 2024
@rfcbot
Copy link

rfcbot commented Oct 4, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 4, 2024
…-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 4, 2024
…-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 4, 2024
…-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 5, 2024
Rollup merge of rust-lang#131177 - workingjubilee:stabilize-const-mut-referees, r=tgross35

 Stabilize 5 `const_mut_refs`-dependent API

Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation:
- const `NonNull::as_mut` rust-lang#91822 (comment)
- const `slice::{first,last}_mut`: rust-lang#83570 (comment)
- const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment)
- const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment)
- const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants