Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap re-builds everything after "x.py check" #130108

Closed
Tracked by #131726
RalfJung opened this issue Sep 8, 2024 · 6 comments · Fixed by #130135
Closed
Tracked by #131726

Bootstrap re-builds everything after "x.py check" #130108

RalfJung opened this issue Sep 8, 2024 · 6 comments · Fixed by #130135
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

RalfJung commented Sep 8, 2024

Some time over the last days, this started happening:

$ ./x.py test ui --bless -- null
$ ./x.py check miri
$ ./x.py test ui --bless -- null

The third invocation should finish immediately, but instead it rebuilds everything. So what is usually a 1s edit-test cycle now takes a full minute.

Cc @rust-lang/bootstrap
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 8, 2024
@RalfJung RalfJung added the A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself label Sep 8, 2024
@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 8, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 8, 2024
@onur-ozkan
Copy link
Member

I wonder if #128871 has anything to do with this.

@RalfJung
Copy link
Member Author

RalfJung commented Sep 8, 2024 via email

@RalfJung
Copy link
Member Author

RalfJung commented Sep 9, 2024

Should we revert that PR then? Or is there some other short-term fix?

This is a significant hurdle for rustc development right now.

@Kobzol
Copy link
Contributor

Kobzol commented Sep 9, 2024

I suppose that we could for now just skip the check command from #128871. I tried the three commands that you have posted, and the last command did not rebuild anything (or rather, everything was fresh). What code should I modify between running these commands to reproduce the behavior that the third command rebuilds a lot of stuff?

@Kobzol
Copy link
Contributor

Kobzol commented Sep 9, 2024

Nevermind, I reproduced it. And the fix with removing check from configuring the linker works. I'll send a PR.

@onur-ozkan onur-ozkan mentioned this issue Sep 9, 2024
Closed
@Kobzol Kobzol mentioned this issue Sep 9, 2024
Merged
@onur-ozkan
Copy link
Member

I think excluding check is quite good short-term fix.

@bors bors closed this as completed in 38e3a57 Sep 9, 2024
RalfJung pushed a commit to RalfJung/miri that referenced this issue Sep 10, 2024
@bors
Auto merge of #130135 - Kobzol:bootstrap-check-linker, r=onur-ozkan
a4de3b8 
Do not skip linker configuration for `check` builds

This essentially reverts a part of rust-lang/rust#128871, to fix rust-lang/rust#130108. This is mostly a hotfix until we can figure out a better way to both avoid rebuilds and avoid configuring the linker for `x check`.

Skipping linker for check builds was causing unexpected rebuilds.

Fixes: rust-lang/rust#130108
@jieyouxu jieyouxu mentioned this issue Oct 15, 2024
Open
5 tasks
@onur-ozkan onur-ozkan mentioned this issue Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
5 participants
@RalfJung @matthiaskrgr @Kobzol @onur-ozkan @rustbot