Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest should warn on redundant --cfg compile-flags #131390

Closed
jieyouxu opened this issue Oct 8, 2024 · 0 comments · Fixed by #131925
Closed

compiletest should warn on redundant --cfg compile-flags #131390

jieyouxu opened this issue Oct 8, 2024 · 0 comments · Fixed by #131925
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Oct 8, 2024

If you specify a revision //@ revisions: foo, compiletest will create a cfg of the same name and run the revision with --cfg foo. The user does not need to manually specify //@ compile-flags: --cfg foo.
@jieyouxu jieyouxu added A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 8, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 8, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2024
@clubby789 clubby789 mentioned this issue Oct 19, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 19, 2024
@matthiaskrgr
Rollup merge of rust-lang#131925 - clubby789:redundant-revision-cfg, …
cfe5389 
…r=jieyouxu

Warn on redundant `--cfg` directive when revisions are used

r? `@jieyouxu`

Fixes rust-lang#131390
Not sure of the best way to test this
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 19, 2024
@matthiaskrgr
Rollup merge of rust-lang#131925 - clubby789:redundant-revision-cfg, …
efd940d 
…r=jieyouxu

Warn on redundant `--cfg` directive when revisions are used

r? ``@jieyouxu``

Fixes rust-lang#131390
Not sure of the best way to test this
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 20, 2024
@rust-timer
Unrolled build for rust-lang#131925
4b28ec2 
Rollup merge of rust-lang#131925 - clubby789:redundant-revision-cfg, r=jieyouxu

Warn on redundant `--cfg` directive when revisions are used

r? ``@jieyouxu``

Fixes rust-lang#131390
Not sure of the best way to test this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn on redundant --cfg directive when revisions are used clubby789/rust
2 participants
@jieyouxu @rustbot