Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for download-rustc improvements #131744

Closed
4 tasks done
onur-ozkan opened this issue Oct 15, 2024 · 2 comments
Closed
4 tasks done

Tracking Issue for download-rustc improvements #131744

onur-ozkan opened this issue Oct 15, 2024 · 2 comments
Assignees
@onur-ozkan
Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@onur-ozkan
Copy link
Member

onur-ozkan commented Oct 15, 2024 •
edited
Loading

These changes are necessary to make download-rustc more stable and less risky:
@onur-ozkan onur-ozkan added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 15, 2024
@RalfJung
Copy link
Member

When not running in CI, if the "library" tree has changed but the "compiler" tree hasn't, avoid recompiling the "compiler" tree.

Isn't this premature? We can do this once the compiler uses the beta library, because then the library folder truly does not affect the stage 0 compiler artifacts. But today, library is an input to the stage 0 compiler artifacts. Also today, library developers can do ./x.py test --stage 0 library/.. so they can already avoid building the compiler.

@onur-ozkan
Copy link
Member Author

Yeah I forgot mentioning #119899.

@onur-ozkan onur-ozkan self-assigned this Oct 16, 2024
This was referenced Oct 17, 2024
Merged
Closed
@jieyouxu jieyouxu mentioned this issue Oct 21, 2024
Closed
@onur-ozkan onur-ozkan mentioned this issue Oct 21, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#132006 - onur-ozkan:131947, r=jieyouxu
56eae72 
don't stage-off to previous compiler when CI rustc is available

Resolves the 4th item in [Tracking Issue for download-rustc improvements](rust-lang#131744).
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 22, 2024
@rust-timer
Unrolled build for rust-lang#132006
729014e 
Rollup merge of rust-lang#132006 - onur-ozkan:131947, r=jieyouxu

don't stage-off to previous compiler when CI rustc is available

Resolves the 4th item in [Tracking Issue for download-rustc improvements](rust-lang#131744).
@onur-ozkan onur-ozkan mentioned this issue Oct 28, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 30, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132267 - onur-ozkan:rustc-if-unchanged-forc…
c66a20e 
…e-library, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang#131744).
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 30, 2024
@workingjubilee
Rollup merge of rust-lang#132267 - onur-ozkan:rustc-if-unchanged-forc…
f90abe7 
…e-library, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang#131744).
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 31, 2024
@rust-timer
Unrolled build for rust-lang#132267
608803f 
Rollup merge of rust-lang#132267 - onur-ozkan:rustc-if-unchanged-force-library, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang#131744).
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Oct 31, 2024
@workingjubilee
Rollup merge of #132267 - onur-ozkan:rustc-if-unchanged-force-library…
635e9f8 
…, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang/rust#131744).
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Nov 1, 2024
@workingjubilee
Rollup merge of #132267 - onur-ozkan:rustc-if-unchanged-force-library…
81e8a96 
…, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang/rust#131744).
@onur-ozkan onur-ozkan mentioned this issue Nov 2, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#132494 - onur-ozkan:library-profile-default…
bfcd9ec 
…, r=jieyouxu

make `download-rustc="if-unchanged"` default for library profile

Since `download-rustc` is tested on CI and rust-lang#132267 makes it effective for library development, we can now make it default for the library profile.

Implements the 3rd item from [this tracking issue](rust-lang#131744).
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 2, 2024
@rust-timer
Unrolled build for rust-lang#132494
f997188 
Rollup merge of rust-lang#132494 - onur-ozkan:library-profile-default, r=jieyouxu

make `download-rustc="if-unchanged"` default for library profile

Since `download-rustc` is tested on CI and rust-lang#132267 makes it effective for library development, we can now make it default for the library profile.

Implements the 3rd item from [this tracking issue](rust-lang#131744).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#131831 - onur-ozkan:improve-rustc-if-unchan…
134459e 
…ged-logic, r=Mark-Simulacrum

extend the "if-unchanged" logic for compiler builds

Implements the first item from [this tracking issue](rust-lang#131744).

In short, we want to make "if-unchanged" logic to check for changes outside of certain allowed directories, and this PR implements that.

See rust-lang#131658 for more context.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 12, 2024
@rust-timer
Unrolled build for rust-lang#131831
81be30b 
Rollup merge of rust-lang#131831 - onur-ozkan:improve-rustc-if-unchanged-logic, r=Mark-Simulacrum

extend the "if-unchanged" logic for compiler builds

Implements the first item from [this tracking issue](rust-lang#131744).

In short, we want to make "if-unchanged" logic to check for changes outside of certain allowed directories, and this PR implements that.

See rust-lang#131658 for more context.
@jieyouxu jieyouxu added the A-bootstrap-config Area: bootstrap `config.toml` and the config system label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RalfJung @jieyouxu @onur-ozkan