Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure script change to disable managing just the LLVM submodule #14822

Closed
larsbergstrom opened this issue Jun 11, 2014 · 1 comment
Closed

Configure script change to disable managing just the LLVM submodule #14822

larsbergstrom opened this issue Jun 11, 2014 · 1 comment

Comments

@larsbergstrom
Copy link
Contributor

Right now, Servo is attempting to build Rust on Travis CI with a prebuilt LLVM. However, there's no configure flag to prevent Rust from still spending a huge amount of time doing git stuff with the LLVM module, as --disable-manage-submodules also prevents it from managing the others.

It would be great if, when you pass a --llvm-root, the configure script doesn't update the LLVM submodule.
@larsbergstrom larsbergstrom changed the title Configure script to disable managing just the LLVM submodule Configure script change to disable managing just the LLVM submodule Jun 11, 2014
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jun 12, 2014
@alexcrichton
configure: Don't sync unused submodules
b5c403d 
If the compiler is built with --{llvm,jemalloc,libuv}-root, then the configure
script can skip updating these submodules.

Closes rust-lang#14822
@alexcrichton alexcrichton mentioned this issue Jun 12, 2014
Closed
@larsbergstrom
Copy link
Contributor Author

@alexcrichton thanks - this is fantastic!

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14822 - Veykril:augmentsSyntaxTokens-vscode, …
673008a 
…r=Veykril

fix: Force disable augmentsSyntaxTokens capability on VSCode

The default textmate grammar for rust in VSCode is pretty brittle, quite often coloring things very differently than we'd like to so we force full semantic highlighting by disabling that config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: Don't sync unused submodules alexcrichton/rust
1 participant
@larsbergstrom