Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core::io cleanup #2004

Closed
catamorphism opened this issue Mar 16, 2012 · 6 comments
Closed

core::io cleanup #2004

catamorphism opened this issue Mar 16, 2012 · 6 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

Address FIXMEs in core::io:

  • Unbuffered operations?
  • Make seekable orthogonal
  • In reader::read_chars(), handle the case where eof occurs in the middle of a Unicode char
  • In reader::read_char(), make sure it's valid to return -1
  • In reader::read_le_uint, deal with EOF
  • Improve forwarding implementation of reader
  • Restructure top-level stdin() and file_reader()
  • fileflags in buffered_file_writer()
  • Make stdin, stdout, stderr consts
  • Figure out why stdin() is different from stdout() and stderr()
  • Optimize mem_buffer::write()
  • Implement read_whole_file() in a low-level way
  • Improve fsync::FILE_res_sync()
@ghost ghost assigned graydon Mar 21, 2012
@Dretch
Copy link
Contributor

Dretch commented Nov 3, 2012

In addition, io::WriterUtil has these methods but there are no corresponding read methods on io::ReaderUtil:

fn write_be_u64(n: u64);
fn write_be_u32(n: u32);
fn write_be_u16(n: u16);
fn write_be_i64(n: i64);
fn write_be_i32(n: i32);
fn write_be_i16(n: i16);
fn write_le_u64(n: u64);
fn write_le_u32(n: u32);
fn write_le_u16(n: u16);
fn write_le_i64(n: i64);
fn write_le_i32(n: i32);
fn write_le_i16(n: i16);
fn write_u8(n: u8);

Dretch added a commit to Dretch/rust that referenced this issue Nov 4, 2012
Dretch added a commit to Dretch/rust that referenced this issue Nov 4, 2012
Dretch pushed a commit to Dretch/rust that referenced this issue Dec 24, 2012
catamorphism added a commit that referenced this issue Dec 24, 2012
Convert core::io to use explicit self (for issue #4118 and issue #2004)
@acertain
Copy link

Unbuffered operations please!

@catamorphism
Copy link
Contributor Author

Nominating for milestone 2 (backwards-compatible).

@kud1ing
Copy link

kud1ing commented May 21, 2013

The proposed changes look similar to what Go offers:

@graydon
Copy link
Contributor

graydon commented May 30, 2013

closing as WONTFIX due to #4248 and specifically #6169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

5 participants