Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make substs(), input_types(), etc on PolyTraitRef preserve the binding level #20664

Closed
nikomatsakis opened this issue Jan 6, 2015 · 3 comments
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@nikomatsakis
Copy link
Contributor

These accessors allow you to skip past the binder in a very lightweight way. This is a bad thing, since the binder is significant. We should refactor them away. While we're at it, it'd might be best if the internal field of a Binder was private. We would then add accesses for every PolyFooBar type for the fields of FooBar. These accessors would yield a Binder<T> for those fields that may contain late-bound regions. I've been moving to this model gradually, but we should finish the job.

@nikomatsakis nikomatsakis changed the title Remove the substs() and self_ty() accesser from PolyTraitRef Make substs(), input_types(), etc on PolyTraitRef preserve the binding level Jan 6, 2015
@kmcallister kmcallister added A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 6, 2015
@jroesch
Copy link
Member

jroesch commented Jan 7, 2015

cc me, 👍

@steveklabnik
Copy link
Member

Traige: FIXMEs still in the code, no change.

@frewsxcv
Copy link
Member

Triage: FIXMEs still in the code, no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

5 participants