Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all callsites to rust_task::yield() #2875

Closed
bblum opened this issue Jul 11, 2012 · 0 comments
Closed

Audit all callsites to rust_task::yield() #2875

bblum opened this issue Jul 11, 2012 · 0 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@bblum
Copy link
Contributor

bblum commented Jul 11, 2012

Might involve changing void yield(bool *killed) to MUST_CHECK bool yield().

To ensure that callers do the being-killed dance. Part of completing #1868.

@ghost ghost assigned bblum Jul 11, 2012
@bblum bblum closed this as completed in 695ab09 Jul 24, 2012
@bblum bblum removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue May 11, 2023
Rustup

This *should* fail because of rust-lang/miri#2874 but it seems we don't actually cover that in our tests...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

1 participant