Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert correctly in task_wait_event in rust_builtin #2890

Closed
catamorphism opened this issue Jul 13, 2012 · 1 comment
Closed

Assert correctly in task_wait_event in rust_builtin #2890

catamorphism opened this issue Jul 13, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Milestone
0.5

Comments

@catamorphism
Copy link
Contributor

As per FIXME in rt/rust_builtin.cpp.
@ghost ghost assigned eholk Jul 13, 2012
@eholk
Copy link
Contributor

eholk commented Jul 25, 2012

For now we aren't going to do this, since it would kill any performance benefits of passing the task in. We can revisit this if we ever add a no-asserts build.

@eholk eholk closed this as completed Jul 25, 2012
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 7, 2021
@bors
Auto merge of rust-lang#7338 - camsteffen:shadow, r=llogic
f8303ad 
Re-write shadow lints

changelog: Move shadow_unrelated to restriction
changelog: The shadow lints find a lot more shadows and are not limited to certain patterns

Drastically simplifies the implementation. Catches a lot more cases.

I removed the "initialization happens here" note. It is not helpful IMO.

Closes rust-lang#318
Fixes rust-lang#2890
Fixes rust-lang#6563
Fixes rust-lang#7588
Fixes rust-lang#7620
RalfJung pushed a commit to RalfJung/rust that referenced this issue May 13, 2023
@bors
Auto merge of rust-lang#2890 - oli-obk:ui_test, r=RalfJung
25c5451 
Add `./miri run-dep` for running a file with test dependencies available

fixes rust-lang#2443
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Update toolchain to nightly-2023-11-21 (rust-lang#2890)
e8ee04b 
We got a bit delayed on the nightly, so this PR closes the gap.

The related Rust changes were:
  - rust-lang#117876
  - rust-lang#117688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@eholk @catamorphism