Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change + mode to pass by-value #3093

Closed
nikomatsakis opened this issue Aug 2, 2012 · 5 comments
Closed

change + mode to pass by-value #3093

nikomatsakis opened this issue Aug 2, 2012 · 5 comments
Labels
A-codegen Area: Code generation
Milestone
0.6

Comments

@nikomatsakis
Copy link
Contributor

Right now we are using + as the "by value" mode, but in fact at runtime it passes by reference. We should change it to pass by value.
@nikomatsakis
Copy link
Contributor Author

assigned to 0.4 milestone as "mode removal" is a big goal

@bblum
Copy link
Contributor

bblum commented Aug 3, 2012

will this affect the semantics of passing @ boxes in +-mode? i wrote TLS with this in mind, and am not sure whether or not it will break if changed.

@nikomatsakis
Copy link
Contributor Author

this would not affect the semantics, I don't think.

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

I think this is possibly-done at this point, but someone should confirm.

@nikomatsakis
Copy link
Contributor Author

This is done.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@nrc
Merge pull request rust-lang#3093 from scampi/issue2633
2f8c1fe 
do not vertically align list items in case the tactic is Horizontal
RalfJung pushed a commit to RalfJung/rust that referenced this issue Sep 30, 2023
@bors
Auto merge of rust-lang#3093 - eduardosm:llvm.x86.sse2.pmadd.wd, r=Ra…
31ac537 
…lfJung

Implement the `llvm.x86.sse2.pmadd.wd` intrinsic
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 1, 2023
@bors
Auto merge of rust-lang#3093 - eduardosm:llvm.x86.sse2.pmadd.wd, r=Ra…
a239576 
…lfJung

Implement the `llvm.x86.sse2.pmadd.wd` intrinsic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@graydon @nikomatsakis @bblum