Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up atomic primitives in libcore #3124

Closed
bblum opened this issue Aug 7, 2012 · 2 comments
Closed

Clean up atomic primitives in libcore #3124

bblum opened this issue Aug 7, 2012 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@bblum
Copy link
Contributor

bblum commented Aug 7, 2012

nasty organisation in pipes and in arc.
@eholk
Copy link
Contributor

eholk commented Aug 7, 2012

I think ARCs call into the runtime to do atomic operations. Now that we have atomic intrinsics, we can use those instead.

I suspect some of the nasty organization in pipes might have been working around compiler bugs, like #3005. The workarounds may not actually be effective though, it could have just been stuff I tried when looking for a workaround that I never removed.

@graydon
Copy link
Contributor

graydon commented May 29, 2013

I think this is closable now (see #5042, #6732, #6740). We have a good atomics library now, arcs use them and/or the atomic intrinsics, and pipes use the atomic intrinsics. Reopen if you disagree.

@graydon graydon closed this as completed May 29, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 21, 2023
@bors
Auto merge of rust-lang#3124 - eduardosm:fix-sse41-round, r=RalfJung
2366a90 
Fix rounding mode check in SSE4.1 round functions

Now it masks out the correct bit and adds some explanatory comments. Also extends the tests.
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@zhassan-aws
Remove unnecessary build step for some workflows (rust-lang#3124)
5131258 
Workflows that run the perf regressions (`scripts/kani-perf.sh`) do not
need to build Kani, as the perf script itself builds Kani in release
mode:


https://github.com/model-checking/kani/blob/dc0978043c52492112e4ad37a617fd3c8100ef1f/scripts/kani-perf.sh#L12

The extra build step was causing Kani to be built two extra times for
the `benchcomp` flow because the workflow was building it in debug mode,
so the script will end up rebuilding it in release mode. This should
save about 3 minutes for the `benchcomp` flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graydon @eholk @bblum