Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core::iter tests are all commented out #3131

Closed
brson opened this issue Aug 7, 2012 · 4 comments
Closed

core::iter tests are all commented out #3131

brson opened this issue Aug 7, 2012 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Aug 7, 2012

this is no good
@catamorphism
Copy link
Contributor

Huh, now there just aren't any tests!

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

much of this is tested in vec now, but not all; I will leave it open.

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

non-critical for 0.6, de-milestoning

@thestinger
Copy link
Contributor

For some reason these are run-pass tests now. I've deprecated the old iter module and I'll make sure there are tests for all of the adaptors in the new one, so this can be closed.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 21, 2023
@bors
Auto merge of rust-lang#3131 - RalfJung:rustup, r=RalfJung
c51ce16 
Rustup

Also fix josh build (they have a `deny(warnings)` that's causing issues).
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@tautschnig
Fix TestLocalToolchain jobs for release push (rust-lang#3131)
5490933 
Upon pushing a release tag, we use the numeric version instead of
"latest", which made `kani-latest` a non-existent folder. See
https://github.com/model-checking/kani/actions/runs/8574249138 for such
an example. Use the `version` variable instead, which will be set to
"latest" or the numeric version as appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @brson @catamorphism @thestinger