Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curl dependency by using python's urllib2 #4059

Closed
lilac opened this issue Nov 29, 2012 · 2 comments
Closed

Remove curl dependency by using python's urllib2 #4059

lilac opened this issue Nov 29, 2012 · 2 comments

Comments

@lilac
Copy link
Contributor

lilac commented Nov 29, 2012

As far as I know, currently rustc depend on curl for downloading files.

$grep curl src/etc/*
src/etc/snapshot.py:    returncode = subprocess.call(["curl", "-o", tmpf, u])
Binary file src/etc/snapshot.pyc matches
src/etc/unicode.py:        os.system("curl -O http://www.unicode.org/Public/UNIDATA/%s"

However, we can actually remove this dependency by python's owner power.

@brson
Copy link
Contributor

brson commented Nov 29, 2012

Cargo also has a runtime dependency on curl for certain download strategies, but I'd consider that an independent issue, and if we removed curl from etc. then we could make it not a build dependency.

@lilac
Copy link
Contributor Author

lilac commented Nov 29, 2012

@brson I change the code to use urllib2, but I later found out that there is not download progress indicator when using this. Thus keep current dependency on curl is reasonable.

@lilac lilac closed this as completed Nov 29, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 8, 2024
Simplify thread blocking tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants