Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commas from trait inheritance list #4061

Closed
brson opened this issue Nov 29, 2012 · 2 comments
Closed

Remove commas from trait inheritance list #4061

brson opened this issue Nov 29, 2012 · 2 comments
Assignees
Milestone

Comments

@brson
Copy link
Contributor

brson commented Nov 29, 2012

The trait inheritance list is a list of type bounds, but for traits. These two constructs mean very similar, if not the same, things, 'in order for a type to be Foo it must be Bar'.

fn f<Foo: Bar>() { }

trait Foo: Bar { }

but the syntaxes suggest dissimilarity with more than one bound:

fn f<Foo: Bar Baz>() { }

trait Foo: Bar, Baz { }

Using space instead of comma in the trait declaration would be more consistent and looks fine.

fn f<Foo: Bar Baz>() { }

trait Foo: Bar Baz { }
@catamorphism
Copy link
Contributor

Sounds good to me.

@ghost ghost assigned brson Dec 7, 2012
@brson
Copy link
Contributor Author

brson commented Dec 7, 2012

Fixed by 10c9d79

@brson brson closed this as completed Dec 7, 2012
RalfJung added a commit to RalfJung/rust that referenced this issue Dec 8, 2024
Use `PathBuf` APIs to correctly do some path manipulation cross-platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants