Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpipes is (partly) unsafe without Pod kind #4074

Closed
brson opened this issue Nov 29, 2012 · 9 comments
Closed

flatpipes is (partly) unsafe without Pod kind #4074

brson opened this issue Nov 29, 2012 · 9 comments

Comments

@brson
Copy link
Contributor

brson commented Nov 29, 2012

The flatpipes module has a mode that works with POD types, and it declares the bounds with Copy Send, but Copy Send is not the same as POD. In particular it allows unique pointers and region pointers. Unique pointers will no longer be Copy once type-based move is implemented. Not sure about regions.

@graydon
Copy link
Contributor

graydon commented Dec 3, 2012

I'm a bit unclear about what this means.

  • Why is an owning pointer going to stop being Copy?
  • What do you intend to capture by POD? Owning pointers and region pointers? Managed pointers? Cycles?

@brson
Copy link
Contributor Author

brson commented Dec 3, 2012

I thought that the class of not-implictly-copyable things was going away with type-based move, but now I can't remember why. Certainly we have been saying that the 'copy' and 'move' keywords would go away, and without 'copy' you can't copy a unique pointer.

I don't understand the word 'capture' in the second question. I intend for POD to mean scalar types and aggregates of scalar types that don't require allocation. No pointers.

@catamorphism
Copy link
Contributor

Not critical for 0.6; de-milestoning

@bstrie
Copy link
Contributor

bstrie commented May 29, 2013

According to brson, this is still relevant. Nominating for Maturity 3, Feature Complete.

@pcwalton
Copy link
Contributor

This is part of extra so probably not a backwards compatibility issue.

@graydon
Copy link
Contributor

graydon commented Jul 18, 2013

accepted for production-ready milestone

@brson
Copy link
Contributor Author

brson commented Jul 18, 2013

If we don't get Pod then we should remove this mode of flatpipes.

@thestinger
Copy link
Contributor

Visiting for triage, still an unsolved issue.

@brson
Copy link
Contributor Author

brson commented Jan 3, 2014

Flatpipes no longer exists.

@brson brson closed this as completed Jan 3, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 8, 2024
cleanup: avoid passing byte slice to anonsocket_read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants