-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pub/priv qualifiers on variants don't seem to get serialized #4082
Comments
If an enum type's only variant is private, disallow dereferencing values of its type, as per rust-lang#818. Due to rust-lang#4082, this only applies to enums that are in the same crate.
@catamorphism Is this done? |
I have a branch where I'm working on this -- it's mostly done, but not quite. I'm on medical leave till the 26th, but if I'm feeling up to it, I'll try to get to it sooner. |
Worked on it today. Mysteriously, locals now get resolved to private enum variants (in other crates) with the same name. I probably won't have time to work on this again till Saturday. |
reproduced on c202430. not a blocker for 0.6 though. |
Not critical for 0.6; de-milestoning |
This is still reproducible. Nominating for production ready. |
accepted for production-ready milestone |
visiting for triage email 2013-07-22. still a problem. (wasted a lot of time because after I transcribed updated versions of the tests, I forgot that we want compilation to fail here, and so I was struggling to figure out why compilation had "started" succeeding in the last two months. ;) ) |
This has been well tested by all the various privacy changes recently. The code above correctly errors and there are multiple tests for this in the test suite. Closing due to being fixed. |
private_variant_1.rs:
private_variant_2.rs:
This compiles successfully, but should fail.
The text was updated successfully, but these errors were encountered: