Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epoch breakage lint for fully qualified paths that do not use crate, self, or super #48722

Closed
Manishearth opened this issue Mar 4, 2018 · 1 comment
Closed

Add epoch breakage lint for fully qualified paths that do not use crate, self, or super #48722

Manishearth opened this issue Mar 4, 2018 · 1 comment
Assignees
@Manishearth
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. WG-epoch Working group: Epoch (2018) management

Comments

@Manishearth
Copy link
Member

Manishearth commented Mar 4, 2018 •
edited
Loading

We need to add a 2018 epoch lint for:

use foo::bar::baz and ::foo::bar::baz where foo is not an external crate name, crate, self, or super. It should suggest use crate::foo::bar::baz; or ::crate::foo::bar::baz instead
@aturon aturon mentioned this issue Mar 4, 2018
Closed
11 tasks
@Manishearth Manishearth added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Mar 4, 2018
@Manishearth Manishearth self-assigned this Mar 4, 2018
@Manishearth Manishearth added the WG-epoch Working group: Epoch (2018) management label Mar 21, 2018
@Manishearth Manishearth changed the title Add epoch lint for fully qualified paths that do not use crate, self, or super Add epoch idiom lint for fully qualified paths that do not use crate, self, or super Mar 21, 2018
@Manishearth Manishearth mentioned this issue Apr 18, 2018
Closed
5 tasks
@Manishearth Manishearth changed the title Add epoch idiom lint for fully qualified paths that do not use crate, self, or super Add epoch breakage lint for fully qualified paths that do not use crate, self, or super Apr 20, 2018
@Manishearth Manishearth mentioned this issue Apr 20, 2018
Merged
@Manishearth
Copy link
Member Author

#50100

bors added a commit that referenced this issue Apr 25, 2018
@bors
Auto merge of #50100 - Manishearth:edition-path-lint, r=nikomatsakis
432fe0c 
Edition breakage lint for absolute paths starting with modules

We plan to enable `extern_absolute_paths` in the 2018 edition. To allow for that, folks must transition their paths in a previous edition to the new one. This makes paths which import module contents via `use module::` or `::module::` obsolete, and we must edition-lint these.

https://internals.rust-lang.org/t/the-great-module-adventure-continues/6678/205?u=manishearth is the current plan for paths.

r? @nikomatsakis

Fixes #48722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. WG-epoch Working group: Epoch (2018) management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Manishearth