Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the libc shim #51465

Closed
est31 opened this issue Jun 10, 2018 · 2 comments
Closed

Remove the libc shim #51465

est31 opened this issue Jun 10, 2018 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@est31
Copy link
Member

est31 commented Jun 10, 2018

PR #51440 has removed the need for the shim. Now the only reason to keep it is so that we can have and enable the rustbuild feature, but this can be done by rustc internal code depending on libc as well. For this we require a change of the upstream libc Cargo.toml though as rustbuild currently is not included there.
@stokhos
Copy link

stokhos commented Jun 10, 2018

Hi est31,
Do I need to triage this issue, since you have already referenced to an older issue.

@Mark-Simulacrum Mark-Simulacrum added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 10, 2018
@Mark-Simulacrum
Copy link
Member

Yep, we'll want to label this as C-cleanup and A-rustbuild, which I've now done.

@est31 est31 closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mark-Simulacrum @est31 @stokhos