Compile core crates before std #51440

est31 · 2018-06-08T18:59:36Z

Right now, many crates used by std need to manually specify dependencies onto crates like core, as they need to be built after core has been built. For some crates from external sources, we provide our own Cargo.toml files so that we can write out that dependency (and other, rustbuild specific things).

This PR splits up the std compilation step in rustbuild into two semi-steps. One which compiles three #![no_std] crates libcore, compiler_builtins, and libstd_unicode, and a second step which compiles the remainder.

Thanks to this, it alleviates the need to specify dependencies onto those crates, and allows libstd to depend on #![no_std] crates from crates.io without modification.

Needed by #51408

r? @Mark-Simulacrum

rust-highfive · 2018-06-08T19:38:04Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/1f/fe/70b051d7b8ff6c486ce223f690b85a8daf42edb09bb2237747469243c828/awscli-1.15.35-py2.py3-none-any.whl (1.3MB)
    0% |▎                               | 10kB 3.3MB/s eta 0:00:01
    1% |▌                               | 20kB 1.5MB/s eta 0:00:01
    2% |▉                               | 30kB 1.7MB/s eta 0:00:01
    3% |█                               | 40kB 1.5MB/s eta 0:00:01
---
    100% |████████████████████████████████| 61kB 5.4MB/s 
Collecting botocore==1.10.35 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/1b/b3/740d993c812453729ac06c41e210997dd94e37adb24dc4aee49eee96fca4/botocore-1.10.35-py2.py3-none-any.whl (4.3MB)
    0% |                                | 10kB 44.1MB/s eta 0:00:01
    0% |▏                               | 20kB 42.4MB/s eta 0:00:01
    0% |▎                               | 30kB 49.7MB/s eta 0:00:01
    0% |▎                               | 40kB 37.1MB/s eta 0:00:01
---
[00:36:54] 
[00:36:54] 
[00:36:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:36:54] Build completed unsuccessfully in 0:29:51
[00:36:54] Makefile:28: recipe for target 'all' failed
[00:36:54] make: *** [all] Error 1
35492 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build
34916 ./obj/build/x86_64-unknown-linux-gnu/native/jemalloc/src
34588 ./obj/build/x86_64-unknown-linux-gnu/native/jemalloc/lib
33884 ./src/llvm-emscripten/lib/Target

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum

Other than one nit I think this looks good (presuming it works).

Mark-Simulacrum · 2018-06-08T22:57:30Z

src/bootstrap/compile.rs


        let _folder = builder.fold_output(|| format!("stage{}-std", compiler.stage));
        builder.info(&format!("Building stage{} std artifacts ({} -> {})", compiler.stage,
                &compiler.host, target));
        run_cargo(builder,
-                  &mut cargo,
+                  &mut core_cargo_invoc,
                  &libstd_stamp(builder, compiler, target),


I think it'd be best to have a dedicated stamp file for core.

rust-highfive · 2018-06-09T00:00:43Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:34:45]    Compiling build_helper v0.1.0 (file:///checkout/src/build_helper)
[00:34:45]    Compiling rustc_codegen_llvm v0.0.0 (file:///checkout/src/librustc_codegen_llvm)
[00:34:45]    Compiling cc v1.0.15
[00:34:46]    Compiling rustc_llvm v0.0.0 (file:///checkout/src/librustc_llvm)
rror[E0463]: can't find crate for `core` which `std` depends on
[00:35:32] error: aborting due to previous error
[00:35:32] 
[00:35:32] For more information about this error, try `rustc --explain E0463`.
[00:35:32] For more information about this error, try `rustc --explain E0463`.
[00:35:32] error: Could not compile `ucd-util`.
[00:35:32] To learn more, run the command again with --verbose.
[00:35:32] 
[00:35:32] 
[00:35:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml"
[00:35:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml"
[00:35:32] expected success, got: exit code: 101
[00:35:32] 
[00:35:32] 
[00:35:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:35:32] Build completed unsuccessfully in 0:29:45
[00:35:32] Makefile:28: recipe for target 'all' failed
[00:35:32] make: *** [all] Error 1
397172 ./.git/objects
397132 ./.git/objects/pack
315016 ./src/llvm
249872 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib
---
128708 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu
128704 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release
127192 ./obj/build/x86_64-unknown-linux-gnu/stage1-std
123808 ./obj/build/bootstrap/debug/incremental/bootstrap-1r3bppl29tbrj
123804 ./obj/build/bootstrap/debug/incremental/bootstrap-1r3bppl29tbrj/s-f1t3fg562a-1u7wzzq-np04vflf21if
91300 ./obj/build/x86_64-unknown-linux-gnu/stage1
91276 ./obj/build/x86_64-unknown-linux-gnu/stage1/lib
89812 ./src/llvm/test/CodeGen
83912 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-09T13:41:41Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

est31 · 2018-06-09T13:46:47Z

So... it seems to fail building rustdoc. Lemme try finding a fix.

Mark-Simulacrum · 2018-06-09T18:27:49Z

We need to add CoreLink to the force_use_stage1 if for Std, otherwise core and related libraries aren't linked in to the stage2 sysroot.

Mark-Simulacrum · 2018-06-09T22:25:34Z

@bors r+

If you don't want to do it yourself, could you open an issue about deleting the libc shim? I think it should no longer be necessary.

bors · 2018-06-09T22:25:35Z

📌 Commit c9c42db has been approved by Mark-Simulacrum

bors · 2018-06-10T03:52:29Z

🔒 Merge conflict

Add CoreLink to Std::run()

est31 · 2018-06-10T13:04:27Z

rebased. re-r? @Mark-Simulacrum

Mark-Simulacrum · 2018-06-10T13:56:24Z

@bors r+

bors · 2018-06-10T13:56:25Z

📌 Commit 046a95d has been approved by Mark-Simulacrum

bors · 2018-06-10T17:54:24Z

⌛ Testing commit 046a95d with merge c40895d133ef007bdca9238fa14128c3f64242c7...

est31 · 2018-06-11T00:23:29Z

travis was green when I enabled the wasm runner. re-r? @Mark-Simulacrum

Mark-Simulacrum · 2018-06-11T00:53:14Z

@bors r+

bors · 2018-06-11T00:53:15Z

📌 Commit 57ca376 has been approved by Mark-Simulacrum

bors · 2018-06-11T02:31:39Z

⌛ Testing commit 57ca376 with merge bd6aaf62d4f7b45ddc37fde1e63b49acb918e2b2...

bors · 2018-06-11T02:38:35Z

💔 Test failed - status-appveyor

rust-highfive · 2018-06-11T03:44:09Z

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:09:13] ---- [run-pass] run-pass/extern-prelude-core.rs stdout ----
[01:09:13] 
[01:09:13] error: compilation failed!
[01:09:13] status: exit code: 101
[01:09:13] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/extern-prelude-core.rs" "--target=i686-unknown-linux-musl" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-musl/native/rust-test-helpers" "-Clinker=/musl-i686/bin/musl-gcc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/auxiliary"
[01:09:13] ------------------------------------------
[01:09:13] 
[01:09:13] ------------------------------------------
[01:09:13] stderr:
[01:09:13] stderr:
[01:09:13] ------------------------------------------
[01:09:13] error: linking with `/musl-i686/bin/musl-gcc` failed: exit code: 1
[01:09:13]   |
[01:09:13]   = note: "/musl-i686/bin/musl-gcc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-Wl,--eh-frame-hdr" "-Wl,-(" "-m32" "-Wl,-melf_i386" "-nostdlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/crt1.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/crti.o" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a.extern_prelude_core0-317d481089b8c8fe83113de504472633.rs.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a.extern_prelude_core1-317d481089b8c8fe83113de504472633.rs.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a.extern_prelude_core2-317d481089b8c8fe83113de504472633.rs.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a.extern_prelude_core3-317d481089b8c8fe83113de504472633.rs.rcgu.o" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/a.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-no-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs" "-L" "/checkout/obj/build/i686-unknown-linux-musl/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/extern-prelude-core/auxiliary" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liballoc_jemalloc-bc383e0f057203ff.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libstd-6a80ec8be7cd108e.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libpanic_unwind-9dc4a36381d3e96f.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libunwind-cb8f79e68e7bccd2.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liballoc_system-5280629c3db400fb.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liblibc-e341d15b13410457.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liballoc-5d430cabf0a1afd6.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libcore-28a7cc3bf4217758.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libcompiler_builtins-e2fcc1d0db99a66e.rlib" "-static" "-Wl,-rpath,/checkout/obj/lib/rustlib/i686-unknown-linux-musl/lib" "-Wl,--enable-new-dtags" "-Wl,-Bdynamic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/crtn.o" "-Wl,-)"
[01:09:13]   = note: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libcompiler_builtins-e2fcc1d0db99a66e.rlib(compiler_builtins-e2fcc1d0db99a66e.compiler_builtins12-8730ddb7c7ab62a37c92724f5ac1c1d7.rs.rcgu.o): In function `memcmp':
[01:09:13]           /checkout/src/rustc/compiler_builtins_shim/../../libcompiler_builtins/src/mem.rs:55: multiple definition of `memcmp'
[01:09:13]           /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liblibc-e341d15b13410457.rlib(memcmp.lo):/build/musl-1.1.18/src/string/memcmp.c:4: first defined here
[01:09:13]           /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libcompiler_builtins-e2fcc1d0db99a66e.rlib(compiler_builtins-e2fcc1d0db99a66e.compiler_builtins12-8730ddb7c7ab62a37c92724f5ac1c1d7.rs.rcgu.o): In function `memcpy':
[01:09:13]           /checkout/src/rustc/compiler_builtins_shim/../../libcompiler_builtins/src/mem.rs:9: multiple definition of `memcpy'
[01:09:13]           /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liblibc-e341d15b13410457.rlib(memcpy.lo):/build/musl-1.1.18/src/string/i386/memcpy.s:7: first defined here
[01:09:13]           /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/libcompiler_builtins-e2fcc1d0db99a66e.rlib(compiler_builtins-e2fcc1d0db99a66e.compiler_builtins12-8730ddb7c7ab62a37c92724f5ac1c1d7.rs.rcgu.o): In function `memcpy':
[01:09:13]           /checkout/src/rustc/compiler_builtins_shim/../../libcompiler_builtins/src/mem.rs:9: multiple definition of `memmove'
[01:09:13]           /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib/liblibc-e341d15b13410457.rlib(memmove.lo):/build/musl-1.1.18/src/string/i386/memmove.s:4: first defined here
[01:09:13]           collect2: error: ld returned 1 exit status
[01:09:13] 
[01:09:13] error: aborting due to previous error
[01:09:13] 
[01:09:13] 
---
[01:09:13] 
[01:09:13] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:09:13] 
[01:09:13] 
[01:09:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-i686-unknown-linux-musl" "--mode" "run-pass" "--target" "i686-unknown-linux-musl" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "/musl-i686/bin/musl-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/i686-unknown-linux-musl/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "6.0.1\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:09:13] 
[01:09:13] 
[01:09:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target i586-unknown-linux-gnu,i686-unknown-linux-musl
[01:09:13] Build completed unsuccessfully in 1:06:19
---
travis_time:end:11a949fe:start=1528688566535580383,finish=1528688566542637180,duration=7056797
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:33d1d173
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03182a24
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pietroalbini · 2018-06-18T08:59:32Z

Ping from triage @est31! It's been a while since we heard from you on this, will you have time to work on this again?

est31 · 2018-06-18T10:25:08Z

I'm waiting on #49219

kennytm · 2018-06-20T22:44:57Z

@bors r-

Wrongly requeued

bors · 2018-07-03T14:43:17Z

☔ The latest upstream changes (presumably #52014) made this pull request unmergeable. Please resolve the merge conflicts.

est31 · 2018-07-03T15:44:42Z

The period of my contributions to Rust upstream has reached an end. Thus I'm unable to continue my work on this. I still think something like this is a great addition. I urge anyone interested in this change to adopt and continue it from here on. Thanks.

rust-highfive assigned Mark-Simulacrum Jun 8, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2018

est31 mentioned this pull request Jun 8, 2018

[WIP]: Remove libbacktrace #51408

Closed

4 tasks

Mark-Simulacrum reviewed Jun 8, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2018

est31 mentioned this pull request Jun 10, 2018

Remove the libc shim #51465

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 10, 2018

est31 added 4 commits June 10, 2018 15:02

Introduce a function to reduce duplication

4e80235

Build core crates before building std crates

027dfe9

Add libcore_stamp

9653b80

Unbreak x.py check

5050a44

est31 force-pushed the core_crates_before_std branch from c9c42db to 5499013 Compare June 10, 2018 13:03

Unbreak x.py doc

046a95d

Add CoreLink to Std::run()

est31 force-pushed the core_crates_before_std branch from 5499013 to 046a95d Compare June 10, 2018 13:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2018

est31 force-pushed the core_crates_before_std branch 2 times, most recently from 2d64d7d to 57ca376 Compare June 11, 2018 00:22

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018

pietroalbini added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 20, 2018

kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2018

est31 closed this Jul 3, 2018

est31 mentioned this pull request May 15, 2019

Replace libbacktrace with a native Rust library #46439

Closed

est31 mentioned this pull request May 22, 2019

integration into libstd gimli-rs/addr2line#89

Closed

14 tasks

Aaron1011 mentioned this pull request Jul 9, 2019

Revival of 'Compile core crates before std' #62513

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compile core crates before std #51440

Compile core crates before std #51440

est31 commented Jun 8, 2018 •

edited

Loading

rust-highfive commented Jun 8, 2018

Mark-Simulacrum left a comment

Mark-Simulacrum Jun 8, 2018

rust-highfive commented Jun 9, 2018

rust-highfive commented Jun 9, 2018

est31 commented Jun 9, 2018

Mark-Simulacrum commented Jun 9, 2018

Mark-Simulacrum commented Jun 9, 2018

bors commented Jun 9, 2018

bors commented Jun 10, 2018

est31 commented Jun 10, 2018

Mark-Simulacrum commented Jun 10, 2018

bors commented Jun 10, 2018

bors commented Jun 10, 2018

est31 commented Jun 11, 2018

Mark-Simulacrum commented Jun 11, 2018

bors commented Jun 11, 2018

bors commented Jun 11, 2018

bors commented Jun 11, 2018

rust-highfive commented Jun 11, 2018

pietroalbini commented Jun 18, 2018

est31 commented Jun 18, 2018

kennytm commented Jun 20, 2018

bors commented Jul 3, 2018

est31 commented Jul 3, 2018

Compile core crates before std #51440

Compile core crates before std #51440

Conversation

est31 commented Jun 8, 2018 • edited Loading

rust-highfive commented Jun 8, 2018

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum Jun 8, 2018

Choose a reason for hiding this comment

rust-highfive commented Jun 9, 2018

rust-highfive commented Jun 9, 2018

est31 commented Jun 9, 2018

Mark-Simulacrum commented Jun 9, 2018

Mark-Simulacrum commented Jun 9, 2018

bors commented Jun 9, 2018

bors commented Jun 10, 2018

est31 commented Jun 10, 2018

Mark-Simulacrum commented Jun 10, 2018

bors commented Jun 10, 2018

bors commented Jun 10, 2018

est31 commented Jun 11, 2018

Mark-Simulacrum commented Jun 11, 2018

bors commented Jun 11, 2018

bors commented Jun 11, 2018

bors commented Jun 11, 2018

rust-highfive commented Jun 11, 2018

pietroalbini commented Jun 18, 2018

est31 commented Jun 18, 2018

kennytm commented Jun 20, 2018

bors commented Jul 3, 2018

est31 commented Jul 3, 2018

est31 commented Jun 8, 2018 •

edited

Loading