Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE in E0657.rs and impl_trait_projections.rs on nightly #51683

Closed
nikomatsakis opened this issue Jun 21, 2018 · 1 comment
Closed

ICE in E0657.rs and impl_trait_projections.rs on nightly #51683

nikomatsakis opened this issue Jun 21, 2018 · 1 comment
Assignees
@oli-obk
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

Nightly ICEs when building two tests from the ui test suite for me:

  • src/test/ui/error-codes/E0657.rs
  • src/test/ui/impl_trait_projections.rs

Transcript here.

Apparently this does not always occur when running the full test suite.

cc @oli-obk
@nikomatsakis nikomatsakis added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2018
@nikomatsakis nikomatsakis mentioned this issue Jun 21, 2018
Merged
@oli-obk oli-obk self-assigned this Jun 21, 2018
bors added a commit that referenced this issue Jun 21, 2018
@bors
Auto merge of #51690 - nikomatsakis:issue-51683-existential-fail, r=o…
ec60dd8 
…li-obk

do not ICE when existing type info is incomplete

Apparently master is kinda ICE-y right now, but only for some people (sadly that set includes me).

I'm not crazy about this PR, because it seems to regress diagnostics a lot, but it *does* fix the problems. I think probably fixing the diagnostics should be done by doing a better job of suppressing errors?

Mitigates  #51683

r? @oli-obk
@oli-obk
Copy link
Contributor

oli-obk commented Jun 27, 2018

Fixed by #51773

@oli-obk oli-obk closed this as completed Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikomatsakis @oli-obk