Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should warn for enabling the same feature twice #53032

Closed
scottmcm opened this issue Aug 3, 2018 · 1 comment · Fixed by #52644
Closed

Should warn for enabling the same feature twice #53032

scottmcm opened this issue Aug 3, 2018 · 1 comment · Fixed by #52644

Comments

@scottmcm
Copy link
Member

scottmcm commented Aug 3, 2018 •
edited
Loading

I just noticed that rustc_mir is enabling in_band_lifetimes twice:

rust/src/librustc_mir/lib.rs

Line 18 in 88e0ff1

#![feature(in_band_lifetimes)]

rust/src/librustc_mir/lib.rs

Line 30 in 88e0ff1

#![feature(in_band_lifetimes)]

Would be good to have a warning to help people notice this kind of superfluous code.
@varkor
Copy link
Member

varkor commented Aug 3, 2018

This is fixed by #52644.

@varkor varkor mentioned this issue Aug 3, 2018
Merged
3 tasks
bors added a commit that referenced this issue Aug 6, 2018
@bors
Auto merge of #52644 - varkor:lib-feature-gate-2, r=withoutboats
b239743 
Add errors for unknown, stable and duplicate feature attributes

- Adds an error for unknown (lang and lib) features.
- Extends the lint for unnecessary feature attributes for stable features to libs features (this already exists for lang features).
- Adds an error for duplicate (lang and lib) features.

```rust
#![feature(fake_feature)] //~ ERROR unknown feature `fake_feature`

#![feature(i128_type)] //~ WARNING the feature `i128_type` has been stable since 1.26.0

#![feature(non_exhaustive)]
#![feature(non_exhaustive)] //~ ERROR duplicate `non_exhaustive` feature attribute
```

Fixes #52053, fixes #53032 and address some of the problems noted in #44232 (though not unused features).

There are a few outstanding problems, that I haven't narrowed down yet:
- [x] Stability attributes on macros do not seem to be taken into account.
- [x] Stability attributes behind `cfg` attributes are not taken into account.
- [x] There are failing incremental tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add errors for unknown, stable and duplicate feature attributes varkor/rust
2 participants
@varkor @scottmcm