Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various FFI run-pass tests probably should be using repr(C) as lint is instructing. #53858

Open
pnkfelix opened this issue Aug 31, 2018 · 2 comments
Open

Various FFI run-pass tests probably should be using repr(C) as lint is instructing. #53858

pnkfelix opened this issue Aug 31, 2018 · 2 comments
Labels
A-repr Area: the `#[repr(stuff)]` attribute A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Aug 31, 2018 •
edited by rustbot
Loading

The following run-pass tests cause the improper_ctypes lint to fire. It would probably be fine (and trivial) to add #[repr(C)] to them.

rust/src/test/run-pass/extern-pass-TwoU16s.rs

Line 17 in c2afca3

pub struct TwoU16s {

rust/src/test/run-pass/extern-pass-TwoU32s.rs

Line 17 in c2afca3

pub struct TwoU32s {

rust/src/test/run-pass/extern-pass-TwoU64s.rs

Line 17 in c2afca3

pub struct TwoU64s {

rust/src/test/run-pass/extern-pass-TwoU8s.rs

Line 17 in c2afca3

pub struct TwoU8s {

rust/src/test/run-pass/extern-return-TwoU16s.rs

Line 13 in c2afca3

pub struct TwoU16s {

rust/src/test/run-pass/extern-return-TwoU32s.rs

Line 13 in c2afca3

pub struct TwoU32s {

rust/src/test/run-pass/extern-return-TwoU64s.rs

Line 13 in c2afca3

pub struct TwoU64s {

rust/src/test/run-pass/extern-return-TwoU8s.rs

Line 13 in c2afca3

pub struct TwoU8s {

rust/src/test/run-pass/foreign-fn-with-byval.rs

Line 14 in c2afca3

pub struct S {

rust/src/test/run-pass/issue-3656.rs

Line 23 in c2afca3

pub struct KEYGEN {

rust/src/test/run-pass/issue-5754.rs

Line 13 in c2afca3

struct TwoDoubles {

rust/src/test/run-pass/issue-6470.rs

Line 14 in c2afca3

pub struct Foo {

(I'm just filing this ticket so I have something to point at from a PR for #53764.)
pnkfelix added a commit to pnkfelix/rust that referenced this issue Sep 3, 2018
@pnkfelix
Add #[allow(improper_ctypes)] to slew of cases that need e.g. `repr…
23dc362 
…(C)`.

See also rust-lang#53858.
pnkfelix added a commit to pnkfelix/rust that referenced this issue Sep 6, 2018
@pnkfelix
Add #[allow(improper_ctypes)] to slew of cases that need e.g. `repr…
8bcf37d 
…(C)`.

See also rust-lang#53858.
@memoryruins memoryruins added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 15, 2018
@asquared31415
Copy link
Contributor

@rustbot claim

@asquared31415 asquared31415 mentioned this issue May 26, 2023
Closed
@asquared31415
Copy link
Contributor

@rustbot release-assignment

@workingjubilee workingjubilee added the A-repr Area: the `#[repr(stuff)]` attribute label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-repr Area: the `#[repr(stuff)]` attribute A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pnkfelix @memoryruins @asquared31415 @workingjubilee