Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-libunwind doesn't use the right compiler for cross targets #59917

Closed
Keruspe opened this issue Apr 12, 2019 · 0 comments · Fixed by #61765
Closed

llvm-libunwind doesn't use the right compiler for cross targets #59917

Keruspe opened this issue Apr 12, 2019 · 0 comments · Fixed by #61765
Labels
A-cross Area: Cross compilation C-bug Category: This is a bug.

Comments

@Keruspe
Copy link
Contributor

Keruspe commented Apr 12, 2019

When settings llvm-libunwind = true the "native" build works just fine, but all cross targets ends up using the host compiler and not the target one for building llvm-libunwind.
I guess we probably should set CC and friends in the libstd build environment so that the cc crates picks the right configured one?
@jonas-schievink jonas-schievink added A-cross Area: Cross compilation C-bug Category: This is a bug. labels Apr 12, 2019
@Keruspe Keruspe mentioned this issue Jun 5, 2019
Closed
Keruspe added a commit to Keruspe/rust that referenced this issue Jun 6, 2019
@Keruspe
libunwind: use correct compiler for cross compilation
76307ea 
Fixes rust-lang#59917

Signed-off-by: Marc-Antoine Perennou <[email protected]>
Keruspe added a commit to Keruspe/rust that referenced this issue Jun 12, 2019
@Keruspe
rustbuild: detect cxx for all targets
59eac97 
Replaces rust-lang#61544
Fixes rust-lang#59917

We need CXX to build llvm-libunwind which can be enabled for all
targets.
As we needed it for all hosts anyways, just move the detection so that
it is ran for all targets (which contains all hosts) instead.

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@Keruspe Keruspe mentioned this issue Jun 12, 2019
Merged
bors added a commit that referenced this issue Jun 25, 2019
@bors
Auto merge of #61765 - Keruspe:rustbuild-cxx, r=alexcrichton
40ab9d2 
rustbuild: detect cxx for all targets

Replaces #61544
Fixes #59917

We need CXX to build llvm-libunwind which can be enabled for alltargets.
As we needed it for all hosts anyways, just move the detection so that it is ran for all targets (which contains all hosts) instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cross Area: Cross compilation C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
2 participants
@Keruspe @jonas-schievink