Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teaching rustpkg how to build C libraries #6403

Closed
catamorphism opened this issue May 10, 2013 · 5 comments · Fixed by #9654
Closed

Teaching rustpkg how to build C libraries #6403

catamorphism opened this issue May 10, 2013 · 5 comments · Fixed by #9654

Comments

@catamorphism
Copy link
Contributor

Sub-bug of #5677

As we discussed today ( https://etherpad.mozilla.org/Rustpkg-Servo-meeting ) this can be done in two ways: shell out and hope there's a C compiler in $PATH, or link rustpkg with the libclang driver. The latter is preferable but is a lot of work.
@ghost ghost assigned catamorphism May 10, 2013
@metajack metajack mentioned this issue May 13, 2013
Closed
@catamorphism catamorphism mentioned this issue Jun 19, 2013
Closed
@graydon
Copy link
Contributor

graydon commented Aug 15, 2013

nominating for feature completeness. we know folks will need this.

@catamorphism
Copy link
Contributor Author

A step towards completing this issue would be to provide a hook that a package script can call to declare a C source file as a dependency ("declared input" for workcache). There would also have to be another hook that a package script could implement to build a given C library from its sources.

@catamorphism
Copy link
Contributor Author

accepted for feature-complete

@catamorphism catamorphism mentioned this issue Oct 1, 2013
Merged
@catamorphism
Copy link
Contributor Author

It looks like this bug won't be finished on deadline, as I have no way to debug the test failure on the Linux bot without VPN access (which I've requested on ServiceNow, but have gotten no response).

@jdm
Copy link
Contributor

jdm commented Oct 7, 2013

That sounds like a request for mozilla.org :: Server Operations: Account Requests on Bugzilla instead.

catamorphism added a commit that referenced this issue Oct 15, 2013
@catamorphism
rustpkg: Support arbitrary dependencies in the install API
0983ebe 
api::install_pkg now accepts an argument that's a list of
(kind, path) dependency pairs. This allows custom package scripts to
declare C dependencies, as is demonstrated in
rustpkg::tests::test_c_dependency_ok.

Closes #6403
bors added a commit that referenced this issue Oct 15, 2013
@bors
auto merge of #9654 : catamorphism/rust/rustpkg-c-dependencies, r=brson
38cc6b9 
r? @brson api::install_pkg now accepts an argument that's a list of
(kind, path) dependency pairs. This allows custom package scripts to
declare C dependencies, as is demonstrated in
rustpkg::tests::test_c_dependency_ok.

Closes #6403
catamorphism added a commit to catamorphism/rust that referenced this issue Oct 21, 2013
@catamorphism
rustpkg: Support arbitrary dependencies in the install API
6796bd4 
api::install_pkg now accepts an argument that's a list of
(kind, path) dependency pairs. This allows custom package scripts to
declare C dependencies, as is demonstrated in
rustpkg::tests::test_c_dependency_ok.

Closes rust-lang#6403
bors added a commit that referenced this issue Oct 23, 2013
@bors
auto merge of #9654 : catamorphism/rust/rustpkg-c-dependencies, r=brson
4cbc8ad 
r? @brson api::install_pkg now accepts an argument that's a list of
(kind, path) dependency pairs. This allows custom package scripts to
declare C dependencies, as is demonstrated in
rustpkg::tests::test_c_dependency_ok.

Closes #6403
@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 30, 2021
@bors
Auto merge of rust-lang#6403 - camsteffen:similar-names-underscore, r…
70386ff 
…=Manishearth

Similar names ignore underscore prefixed names

changelog: Ignore underscore-prefixed names for similar_names

IMO, this lint is not very helpful for underscore-prefixed variables. Usually they are unused or are just there to ignore part of a destructuring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustpkg: Support arbitrary dependencies in the install API catamorphism/rust
3 participants
@graydon @jdm @catamorphism