Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the generic passage on register_dtor still relevant? #66572

Closed
hellow554 opened this issue Nov 20, 2019 · 3 comments · Fixed by #67230
Closed

Is the generic passage on register_dtor still relevant? #66572

hellow554 opened this issue Nov 20, 2019 · 3 comments · Fixed by #67230
Assignees
@rustbot
Labels
A-thread-locals Area: Thread local storage (TLS) E-help-wanted Call for participation: Help is requested to fix this issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@hellow554
Copy link
Contributor

hellow554 commented Nov 20, 2019 •
edited by rustbot
Loading

rust/src/libstd/sys/unix/fast_thread_local.rs

Line 12 in ab6cb01

// Due to rust-lang/rust#18804, make sure this is not generic!

The corresponding issue #18804 has been closed by PR #52635, so is that passage still relevant or can it be removed?

This issue has been assigned to @chansuke via this comment.
@hellow554 hellow554 changed the title Is genericity on linked functions still relevant? Is the generic passage on register_dtor still relevant? Nov 20, 2019
@jonas-schievink jonas-schievink added A-thread-locals Area: Thread local storage (TLS) T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 20, 2019
@Mark-Simulacrum
Copy link
Member

Seems likely it can be removed. Marking as E-help-wanted; I don't expect we'll do this ourselves but if someone files a PR removing the comment I think it's likely we can accept that pretty easily.

@Mark-Simulacrum Mark-Simulacrum added the E-help-wanted Call for participation: Help is requested to fix this issue. label Dec 5, 2019
@chansuke
Copy link
Contributor

Hi:) I would like to work on this.

@chansuke
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this Dec 11, 2019
@chansuke chansuke mentioned this issue Dec 11, 2019
Merged
@bors bors closed this as completed in 3cf7996 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-thread-locals Area: Thread local storage (TLS) E-help-wanted Call for participation: Help is requested to fix this issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove irelevant comment on register_dtor chansuke/rust
5 participants
@chansuke @hellow554 @jonas-schievink @Mark-Simulacrum @rustbot