Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo doc test not colored #72915

Closed
pickfire opened this issue Jun 2, 2020 · 2 comments · Fixed by #74293
Closed

Cargo doc test not colored #72915

pickfire opened this issue Jun 2, 2020 · 2 comments · Fixed by #74293
Labels
A-doctests Area: Documentation tests, run by rustdoc C-feature-request Category: A feature request, i.e: not implemented / a PR. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pickfire
Copy link
Contributor

pickfire commented Jun 2, 2020

Problem

2020-06-02-203022_1366x768_scrot

Steps

  1. cargo +nightly t

Possible Solution(s)

Most likely some flags not passed to rustc.

Notes

Output of cargo version: cargo 1.45.0-nightly (9fcb8c1d2 2020-05-25)

> uname -a
Linux arch 5.6.15-zen2-1-zen rust-lang/cargo#1 ZEN SMP PREEMPT Thu, 28 May 2020 16:49:25 +0000 x86_64 GNU/Linux
> os/distro
Arch Linux
> rustup --version
rustup 1.21.1 (7832b2ebe 2019-12-20)
# release channel
nightly
@ehuss ehuss transferred this issue from rust-lang/cargo Jun 2, 2020
@ehuss
Copy link
Contributor

ehuss commented Jun 2, 2020

Thanks for the report. I have transferred this to rust-lang/rust, because this is a rustdoc issue. I could have sworn there was already an issue for this, but I can't find it. I recall investigating this in the past, and the fix wasn't exactly trivial.

@pickfire
Copy link
Contributor Author

pickfire commented Jun 2, 2020

Yes, I think this might have been a regression. Maybe we have a regression test this time but I am not sure if the tests are able to check color.

@Elinvynia Elinvynia added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 3, 2020
@crlf0710 crlf0710 added the C-bug Category: This is a bug. label Jun 11, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 13, 2020
Merged
@jyn514 jyn514 added the A-doctests Area: Documentation tests, run by rustdoc label Aug 27, 2020
@camelid camelid added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-bug Category: This is a bug. labels Nov 11, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 15, 2020
@GuillaumeGomez
Rollup merge of rust-lang#74293 - GuillaumeGomez:rustdoc-test-compile…
00b594b 
…r-output-color, r=jyn514

Rustdoc test compiler output color

Fixes rust-lang#72915

We just need to be sure it doesn't break rustdoc doctests' compilation checks. Maybe some other unforeseen consequences too?

r? `@ehuss`
cc `@rust-lang/rustdoc`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 16, 2020
@GuillaumeGomez
Rollup merge of rust-lang#74293 - GuillaumeGomez:rustdoc-test-compile…
a06fb3c 
…r-output-color, r=jyn514

Rustdoc test compiler output color

Fixes rust-lang#72915

We just need to be sure it doesn't break rustdoc doctests' compilation checks. Maybe some other unforeseen consequences too?

r? ``@ehuss``
cc ``@rust-lang/rustdoc``
@bors bors closed this as completed in 81f9feb Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-doctests Area: Documentation tests, run by rustdoc C-feature-request Category: A feature request, i.e: not implemented / a PR. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rustdoc test compiler output color GuillaumeGomez/rust
6 participants
@ehuss @crlf0710 @pickfire @jyn514 @camelid @Elinvynia