Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When TERM=dumb, rust build dies mysteriously #7431

Closed
pnkfelix opened this issue Jun 27, 2013 · 1 comment · Fixed by #7436
Closed

When TERM=dumb, rust build dies mysteriously #7431

pnkfelix opened this issue Jun 27, 2013 · 1 comment · Fixed by #7436

Comments

@pnkfelix
Copy link
Member 

% echo $TERM
dumb
% x86_64-apple-darwin/stage1/bin/rustc --cfg stage1  -O -Z no-debug-borrows --target=x86_64-apple-darwin   -o x86_64-apple-darwin/stage1/lib/rustc/x86_64-apple-darwin/lib/libsyntax.dylib /Users/fklock/Dev/Mozilla/rust.git/src/libsyntax/syntax.rs
/Users/fklock/Dev/Mozilla/rust.git/src/libsyntax/ext/pipes/proto.rs:148:9: 148:20 warning: error: %

Discussion in #rust implies that this might have been injected by SHA: 0ae203a
@lilyball
Copy link
Contributor

Looks like the problem is reset() calls unwrap() directly on the results of looking up op, which dumb doesn't support. This used to work because it used to only do this if color_supported, but with the removal of that boolean, it always tries to emit the op code.

This was a problem before, if you could find a terminfo that defined setaf, setab, and had colors >= 16, but did not define op.

@lilyball lilyball mentioned this issue Jun 27, 2013
Merged
bors added a commit that referenced this issue Jun 28, 2013
@bors
auto merge of #7436 : kballard/rust/term-dumb, r=cmr
4e4e2f7 
Unlike fg() and bg(), we haven't already checked for the presence of
"op" in the terminfo when we call reset(), so we need to handle the case
where it's missing.

Also update the warn!() lines to avoid double-quoting the output.

Fixes #7431.
@bors bors closed this as completed in d9fed2b Jun 28, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 15, 2021
@bors
Auto merge of rust-lang#7431 - DevinR528:fix-macro-brace, r=llogiq
3cc6778 
Fix emitting in nested (proc_)macros for nonstandard_macro_braces lint

fixes rust-lang#7422

changelog: fixes false positives in [`nonstandard_macro_braces`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Teach extra::term::Terminal.reset() to handle missing op lilyball/rust
2 participants
@lilyball @pnkfelix