Tracking issue for const `Pin` methods #76654

CDirkx · 2020-09-12T23:30:09Z

Constify methods of core::pin::Pin under the feature const_pin.

Implementation: #76655

Methods in const_pin (stable since #130136):

new
new_unchecked
get_ref
into_ref
get_mut
get_unchecked_mut
static_ref
static_mut

Methods in const_pin2:

into_inner
into_inner_unchecked

The const_pin2 methods will need #[rustc_allow_const_fn_unstable(const_precise_live_drops)] but that has been approved here.

The text was updated successfully, but these errors were encountered:

Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654

ecstatic-morse · 2020-09-13T00:48:07Z

As you mention in #76655 PR, the implementation of some of these methods depends on the unstable const_precise_live_drops feature. Future readers should check the status of that feature before attempting to stabilize these. #76618 will ensure that this does not happen by accident.

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

@ecstatic-morse

Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse

Partially stabilize const_pin Tracking issue rust-lang#76654. Eight of these methods can be made const-stable. The remainder are blocked on rust-lang#73255.

Rollup merge of rust-lang#130136 - GKFX:stabilize-const-pin, r=dtolnay Partially stabilize const_pin Tracking issue rust-lang#76654. Eight of these methods can be made const-stable. The remainder are blocked on rust-lang#73255.

RalfJung · 2024-10-18T13:45:57Z

@dtolnay wrote

I'd be happy to take a separate PR for the const-stabilizing of into_inner + into_inner_unchecked. Procedurally I think a fresh FCP would be required.

So, let's get that train rolling -- @rust-lang/libs-api can we const-stabilize the const_pin2 feature gate, which guards Pin::into_inner and Pin::into_inner_unchecked (already stable outside const)?

dtolnay · 2024-10-18T14:29:12Z

@rfcbot fcp merge

rfcbot · 2024-10-18T14:29:14Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

tgross35 · 2024-10-18T16:43:30Z

can we const-stabilize the const_pin2 feature gate, which guards Pin::into_inner and Pin::into_inner_unchecked

Since this will likely be the same release cycle, the const_pin2 items can probably just be grouped back into const_pin.

tgross35 · 2024-11-06T22:54:07Z

@Amanieu @BurntSushi @m-ou-se could this get one more check? So we avoid splitting const_pin if fcp doesn't make the next branch.

rfcbot · 2024-11-06T23:35:25Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2024-11-16T23:38:47Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

RalfJung · 2024-11-17T07:11:38Z

Stabilization PR is up at #133127

…ss35 Stabilize const_pin_2 Tracking issue rust-lang#76654; review before FCP in progress.

Rollup merge of rust-lang#131904 - GKFX:stabilize-const-pin-2, r=tgross35 Stabilize const_pin_2 Tracking issue rust-lang#76654; review before FCP in progress.

CDirkx mentioned this issue Sep 12, 2020

Make some methods of Pin unstable const #76655

Merged

jyn514 added A-const-fn T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 13, 2020

CDirkx mentioned this issue Feb 15, 2021

Make some Option, Result methods unstably const #82130

Merged

inquisitivecrystal mentioned this issue Jul 29, 2021

Tracking issue for #![feature(const_precise_live_drops)] #73255

Open

1 task

GKFX mentioned this issue Sep 9, 2024

Partially stabilize const_pin #130136

Merged

RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Oct 18, 2024

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 18, 2024

dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Oct 18, 2024

GKFX mentioned this issue Oct 18, 2024

Stabilize const_pin_2 #131904

Merged

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 6, 2024

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 16, 2024

rfcbot added the to-announce Announce this issue on triage meeting label Nov 16, 2024

rustbot mentioned this issue Nov 16, 2024

Tracking issue for release notes of #76654: Tracking issue for const Pin methods #133124

Open

3 tasks

RalfJung mentioned this issue Nov 17, 2024

stabilize const_pin_2 #133127

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 20, 2024

Rollup merge of rust-lang#131904 - GKFX:stabilize-const-pin-2, r=tgro…

2595118

…ss35 Stabilize const_pin_2 Tracking issue rust-lang#76654; review before FCP in progress.

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 20, 2024

Unrolled build for rust-lang#131904

d982e04

Rollup merge of rust-lang#131904 - GKFX:stabilize-const-pin-2, r=tgross35 Stabilize const_pin_2 Tracking issue rust-lang#76654; review before FCP in progress.

apiraino removed the to-announce Announce this issue on triage meeting label Nov 21, 2024

RalfJung added A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) and removed A-const-fn labels Dec 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for const `Pin` methods #76654

Tracking issue for const `Pin` methods #76654

CDirkx commented Sep 12, 2020 •

edited by RalfJung

Loading

ecstatic-morse commented Sep 13, 2020

RalfJung commented Oct 18, 2024 •

edited

Loading

dtolnay commented Oct 18, 2024

rfcbot commented Oct 18, 2024 •

edited by m-ou-se

Loading

tgross35 commented Oct 18, 2024

tgross35 commented Nov 6, 2024

rfcbot commented Nov 6, 2024

rfcbot commented Nov 16, 2024

RalfJung commented Nov 17, 2024

Tracking issue for const Pin methods #76654

Tracking issue for const Pin methods #76654

Comments

CDirkx commented Sep 12, 2020 • edited by RalfJung Loading

ecstatic-morse commented Sep 13, 2020

RalfJung commented Oct 18, 2024 • edited Loading

dtolnay commented Oct 18, 2024

rfcbot commented Oct 18, 2024 • edited by m-ou-se Loading

tgross35 commented Oct 18, 2024

tgross35 commented Nov 6, 2024

rfcbot commented Nov 6, 2024

rfcbot commented Nov 16, 2024

RalfJung commented Nov 17, 2024

Tracking issue for const `Pin` methods #76654

Tracking issue for const `Pin` methods #76654

CDirkx commented Sep 12, 2020 •

edited by RalfJung

Loading

RalfJung commented Oct 18, 2024 •

edited

Loading

rfcbot commented Oct 18, 2024 •

edited by m-ou-se

Loading