Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py setup creates config.toml in root directory, even if one is running in a different directory #78509

Closed
pnkfelix opened this issue Oct 29, 2020 · 4 comments
Closed

x.py setup creates config.toml in root directory, even if one is running in a different directory #78509

pnkfelix opened this issue Oct 29, 2020 · 4 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

If you run x.py build in a directory with no config.toml, it suggests you run x.py setup first.

I did that.

Then I ran x.py build again. And it made the same suggestion.

The suggestion wasn't wrong, since there was no config.toml in my current directory, even after running x.py setup; the problem was that running x.py setup is generating the config.toml in the source root, rather than in the current directory.
@pnkfelix pnkfelix added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 29, 2020

@pnkfelix are you using different config.toml files depending on the directory? Or did you intend to run x.py from the top-level directory?

@jyn514
Copy link
Member

jyn514 commented Oct 29, 2020

Or did you intend to run x.py from the current directory but use the top-level config.toml?

@cuviper
Copy link
Member

cuviper commented Oct 29, 2020

Normally x.py uses the config from the current directory, so I would expect x.py setup to create the same. I don't know about pnkfelix, but I often want to try a single source tree with multiple configs (bundled vs system LLVM, alt debug settings, etc.).

@jyn514 jyn514 added the C-bug Category: This is a bug. label Oct 30, 2020
jyn514 added a commit to jyn514/rust that referenced this issue Oct 30, 2020
@jyn514
Create config.toml in the current directory, not the top-level directory
8cf7d66 
See rust-lang#78509 for discussion.
@jyn514 jyn514 mentioned this issue Oct 30, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Oct 31, 2020
@Dylan-DPC
Rollup merge of rust-lang#78550 - jyn514:setup, r=Mark-Simulacrum
61eb1a8 
x.py setup: Create config.toml in the current directory, not the top-level directory

See rust-lang#78509 for discussion.

r? @pnkfelix
cc @cuviper @Mark-Simulacrum
m-ou-se added a commit to m-ou-se/rust that referenced this issue Oct 31, 2020
@m-ou-se
Rollup merge of rust-lang#78550 - jyn514:setup, r=Mark-Simulacrum
1ac678f 
x.py setup: Create config.toml in the current directory, not the top-level directory

See rust-lang#78509 for discussion.

r? @pnkfelix
cc @cuviper @Mark-Simulacrum
m-ou-se added a commit to m-ou-se/rust that referenced this issue Oct 31, 2020
@m-ou-se
Rollup merge of rust-lang#78550 - jyn514:setup, r=Mark-Simulacrum
c0f356d 
x.py setup: Create config.toml in the current directory, not the top-level directory

See rust-lang#78509 for discussion.

r? @pnkfelix
cc @cuviper @Mark-Simulacrum
@jyn514
Copy link
Member

jyn514 commented Jan 1, 2021

This was fixed in #78550.

@jyn514 jyn514 closed this as completed Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cuviper @pnkfelix @jyn514