Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Headers in docs have shrunk #85389

Closed
camelid opened this issue May 16, 2021 · 1 comment · Fixed by #85396
Closed

rustdoc: Headers in docs have shrunk #85389

camelid opened this issue May 16, 2021 · 1 comment · Fixed by #85396
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented May 16, 2021

beta

image

nightly

image
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels May 16, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2021
@camelid
Copy link
Member Author

camelid commented May 16, 2021

cc @rust-lang/rustdoc

@jsha jsha mentioned this issue May 17, 2021
Merged
@jyn514 jyn514 changed the title rustdoc: Headers in docs have shrunken rustdoc: Headers in docs have shrunk May 17, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 18, 2021
@Dylan-DPC
Rollup merge of rust-lang#85396 - jsha:top-doc-font-sizes, r=Guillaum…
8a9a7a6 
…eGomez

rustdoc: restore header sizes

The `<details>` toggle work changed the relationship from #main to the top-doc docblock so it was no longer a parent relationship but a great-grandparent relationship. This updates the CSS rules that set the heading sizes so they still apply.

Fixes rust-lang#85389

r? `@camelid`
@bors bors closed this as completed in 9b5cf64 May 19, 2021
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: restore header sizes jsha/rust
3 participants
@apiraino @camelid @rustbot