Small typo in noise.rs benchmark #8574
Comments
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Nov 21, 2022
Also move it to nursery so that the false-positives can be dealt with. CC rust-lang#8574
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Nov 21, 2022
Make it clear that `or_fun_call` can be a false-positive Also move it to nursery so that the false-positives can be dealt with. CC rust-lang#8574 changelog: [`or_fun_call`]: Mention false-positives, move to nursery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I'm the original author of it, I was wondering for a looooong time, why rust produces a slightly different result, than all other languages. It seemed like a proper ASCII perlin noise, but at the same time it was different for sure.
Found the bug, typo on this line:
https://github.com/mozilla/rust/blob/master/src/test/bench/noise.rs#L29
Should be:
grad.x * sp.x + grad.y * sp.yI'm not familiar with rust's workflow, so I guess it will be easier for someone who is to just commit that fix. Hence I'm not creating a pull request.
The text was updated successfully, but these errors were encountered: