-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build 1.53.0 from official tarball due to miri #86436
Comments
cc #86286 |
Possibly the fix landed after 1.53 was branched? Anyway, the stable release tarballs do not contain Miri any more (they were never intended to), so I'd say this is fixed by #86568. |
Yeah, the git fix landed with #85402 which reached stable with 1.54.0. |
I should also mention that Miri is simply not supported on stable. I don't know how exactly you are building rustc from that tarball, but you might have enabled too many "extra tools"? |
Just have hit this error with 1.53 tarball with You can see miri is present in the end:
I believe this bug should be reopened and retitled because |
The bug will, I think, be fixed in the next release since Miri is simply not part of the tarball any more. I think the bug you are asking is already open: #74709 |
I have just found #86568 which should solve the issue on nightly but ideally it'd be backported to beta and stable. |
Backporting to stable makes little sense (unless there's a point release, which I wouldn't expect). Backporting to beta already happened in #86413. |
Reading the comments, I missed a solution for building Rust 1.53.0 with
but with 1.53.0 the |
One workaround is to create and initialize git repository in the directory where you want to build Rust (preferably before unpacking Rust to save time). |
@paulmenzel I haven't tried it but shouldn't setting the
So if you just want cargo, I'd try |
Thank you. Sorry, I didn’t mention it. I had tried it, and it did not work. |
@Mark-Simulacrum is that expected that Miri is built even when |
In the sense that I'm not surprised, yes -- tools is pretty poorly supported around rustbuild, it's not something I have in cache to think about when we introduce new code so its easy to miss a dependency there. It should likely get fixed to skip building miri when tools doesn't include it though. |
Sorry, I do not understand. It’d be great if you rephrased it. |
Can I patch the source some how (delete the miri files?) to fix the build? |
I'm not sure why the exclude switch is being ignored; you'll need to provide a full verbose log to try and dig in on what specifically is causing miri to be invoked despite the exclude. FWIW we don't generally expect people to use x.py build in dist tarballs -- x.py dist/install are more likely to work. |
How can I increase the verbosity?
|
I'd be happy to accept a PR (though not sure that's quite the place to update, seems OK though) that adds some text about preferring x.py dist/install when using the tarballs. |
Log from (Sorry, the screen buffer was too small, but hopefully the messages still help.) |
Looks like this will be fixed by #87282, it's getting invoked through extended = true (which directly runs the dist step for miri, ignoring --exclude). I have not reviewed that PR yet, but expect to do so soon; going to add this issue to the fixes list on it though. |
I think you can fix this on 1.53 by patching the source here https://github.com/rust-lang/rust/blob/1.53.0/src/bootstrap/dist.rs#L1176 to return None from that step. You may need to set deny-warnings = false or fix some other compiler warnings in order to build with that function stubbed out like that. |
As the Rust 1.52.1 release builds and installs just fine, did anybody find the commit causing the regression? |
Possibly in 1.52.1 Miri happened to build on stable even outside a git repo? That would have been a happy accident, we never tested this. This commit landed with #83922 which first shipped in 1.53. Maybe older versions of vergen failed more gracefully when there is no git repo. |
FWIW Miri was present in version 1.43 http://web.archive.org/web/20200930154630/https://packages.msys2.org/package/mingw-w64-x86_64-rust |
Hi there, I tried to build Rust 1.53.0 from the source tarball downloaded from https://static.rust-lang.org/dist/rustc-1.53.0-src.tar.gz and it failed to compile due to
cargo-miri
could not locate the Git repository.After a quick search, the issue supposedly should have been fixed in rust-lang/miri@e5b3400 but for some reason, the fix didn't land in the final distribution despite in #84182 it was stated that the fix would be included in the next stable release.
Here is the backtrace:
Backtrace
The text was updated successfully, but these errors were encountered: