Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to edition guide from lints. #86996

Closed
nikomatsakis opened this issue Jul 9, 2021 · 0 comments · Fixed by #87885
Closed

Link to edition guide from lints. #86996

nikomatsakis opened this issue Jul 9, 2021 · 0 comments · Fixed by #87885
Assignees
@m-ou-se
Labels
A-edition-2021 Area: The 2021 edition D-edition Diagnostics: An error or lint that should account for edition differences.

Comments

@nikomatsakis
Copy link
Contributor

This was opened from the Rust 2021 Project board from a note by @m-ou-se. I believe the intent is that every Rust 2021 Edition lint should link to the edition guide. I think what would be nice is if that was part of the link metadata.
@m-ou-se m-ou-se self-assigned this Jul 9, 2021
@m-ou-se m-ou-se added A-edition-2021 Area: The 2021 edition D-edition Diagnostics: An error or lint that should account for edition differences. labels Jul 9, 2021
@m-ou-se m-ou-se mentioned this issue Aug 9, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 11, 2021
@JohnTitor
Rollup merge of rust-lang#87885 - m-ou-se:edition-guide-links, r=rylev
3b8d386 
Link to edition guide instead of issues for 2021 lints.

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes  rust-lang#86996
JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 11, 2021
@JohnTitor
Rollup merge of rust-lang#87885 - m-ou-se:edition-guide-links, r=rylev
3144602 
Link to edition guide instead of issues for 2021 lints.

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes  rust-lang#86996
@bors bors closed this as completed in 3d733f6 Aug 12, 2021
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 3, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87885 - m-ou-se:edition-guide-links, r=rylev
fd5427b 
Link to edition guide instead of issues for 2021 lints.

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes  rust-lang#86996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-ou-se m-ou-se

Labels
A-edition-2021 Area: The 2021 edition D-edition Diagnostics: An error or lint that should account for edition differences.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link to edition guide instead of issues for 2021 lints. m-ou-se/rust
2 participants
@nikomatsakis @m-ou-se