Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Refactor get_all_types so args is fully shared between loop iterations #90779

Open
camelid opened this issue Nov 10, 2021 · 2 comments
Open

rustdoc: Refactor get_all_types so args is fully shared between loop iterations #90779

camelid opened this issue Nov 10, 2021 · 2 comments
Assignees
@JmPotato
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Nov 10, 2021 •
edited by rustbot
Loading

  1. Refactor add_generics_and_bounds_as_types so it handles all types, not just type parameters.
  2. Remove the !args.is_empty() conditional in get_fn_inputs_and_outputs.
  3. Extend all_types with args at the end of the loop.

cc @GuillaumeGomez
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 10, 2021
@camelid camelid self-assigned this Nov 10, 2021
@camelid
Copy link
Member Author

camelid commented Nov 10, 2021

Assigning myself for now since I may look into it.

@camelid camelid mentioned this issue Dec 28, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 29, 2021
@matthiaskrgr
Rollup merge of rust-lang#92340 - camelid:search-index-cleanup, r=Gui…
0e41194 
…llaumeGomez

rustdoc: Start cleaning up search index generation

I'm trying to simplify and clean up the code, partly to make rust-lang#90779 easier.

r? `@GuillaumeGomez`
@camelid camelid removed their assignment Jan 4, 2022
@camelid camelid added the E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. label Jan 4, 2022
@JmPotato
Copy link
Contributor

JmPotato commented Mar 3, 2022

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmPotato JmPotato

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JmPotato @camelid