Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention in's use for visibility paths, aka pub(in path), in the keyword docs #93609

Closed
MarkDDR opened this issue Feb 3, 2022 · 1 comment · Fixed by #93692
Closed

Mention in's use for visibility paths, aka pub(in path), in the keyword docs #93609

MarkDDR opened this issue Feb 3, 2022 · 1 comment · Fixed by #93692
Assignees
@mfrw
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@MarkDDR
Copy link

MarkDDR commented Feb 3, 2022 •
edited by rustbot
Loading

The std lib keyword docs for the keyword in only mentions in's use with for loops, but that keyword has one other use that I am aware of, specifying a visibility path for an item, pub(in path). This should be documented there as well.
@JohnTitor JohnTitor added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Feb 3, 2022
@jyn514 jyn514 added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Feb 4, 2022
@mfrw
Copy link
Contributor

mfrw commented Feb 4, 2022

@rustbot claim

@mfrw mfrw mentioned this issue Feb 6, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Mar 19, 2022
@Dylan-DPC
Rollup merge of rust-lang#93692 - mfrw:mfrw/document-keyword-in, r=dt…
c437730 
…olnay

keyword_docs: document use of `in` with `pub` keyword

Signed-off-by: Muhammad Falak R Wani <[email protected]>

Fixes: rust-lang#93609
@bors bors closed this as completed in 463e516 Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfrw mfrw

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keyword_docs: document use of in with pub keyword mfrw/rust
4 participants
@MarkDDR @mfrw @jyn514 @JohnTitor