Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#97027 #97204

Closed
rust-highfive opened this issue May 20, 2022 · 0 comments · Fixed by #97247
Closed

miri no longer builds after rust-lang/rust#97027 #97204

rust-highfive opened this issue May 20, 2022 · 0 comments · Fixed by #97247
Assignees
@cuviper @eddyb @RalfJung @oli-obk
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #97027, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @cuviper, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels May 20, 2022
@RalfJung RalfJung mentioned this issue May 20, 2022
Merged
bors added a commit to rust-lang/miri that referenced this issue May 20, 2022
@bors
Auto merge of #2130 - RalfJung:rustup, r=RalfJung
d419efd 
rustup

`Display` of `Ref`/`RefMut` was broken by rust-lang/rust#97027, let's deref them to use the underlying reference `Display`.

Cc rust-lang/rust#97204
@cuviper cuviper self-assigned this May 20, 2022
@cuviper cuviper mentioned this issue May 20, 2022
Merged
@RalfJung RalfJung mentioned this issue May 21, 2022
Merged
@bors bors closed this as completed in 74b1369 May 21, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this issue May 22, 2022
@JohnTitor
Rollup merge of rust-lang#97225 - cuviper:ref-display, r=scottmcm
d22ebf0 
Fix `Display` for `cell::{Ref,RefMut}`

These guards changed to pointers in rust-lang#97027, but their `Display` was
formatting that field directly, which made it show the raw pointer
value. Now we go through `Deref` to display the real value again.

Miri noticed this change, rust-lang#97204, so hopefully that will be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuviper cuviper

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Miri RalfJung/rust
5 participants
@cuviper @eddyb @RalfJung @oli-obk @rust-highfive