-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ICE in rustdoc when using Fn
bounds
#100205
Conversation
r? @notriddle (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
cc @rust-lang/rustdoc This fixes a pretty severe beta regression. |
Actually, this beta is about to be released as 1.63. @Mark-Simulacrum is it too late to get this in 1.63? |
@bors p=1 |
@bors r+ |
Unilaterally marking as beta-accepted since it's a pretty small change to fix a severe issue and the release is being cut imminently. |
…Simulacrum [stable] 1.63.0 release Includes cherry picks of: * rust-lang#100207 * rust-lang/rust-clippy#9302 * Avoid ICE in rustdoc when using Fn bounds rust-lang#100205 r? `@Mark-Simulacrum`
…mulacrum [beta] 1.64.0 branching Includes cherry picks of: * rust-lang#100207 * rust-lang/rust-clippy#9302 * rust-lang/rust@49b1904 (explicit_auto_deref into nursery) * Avoid ICE in rustdoc when using Fn bounds rust-lang#100205 r? `@Mark-Simulacrum`
☀️ Test successful - checks-actions |
Finished benchmarking commit (8d1fa71): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Fixes #100143