Rollup of 8 pull requests #101037

GuillaumeGomez · 2022-08-26T12:08:52Z

Successful merges:

BTree: evaluate static type-related check at compile time #95005 (BTree: evaluate static type-related check at compile time)
Add comments about stdout locking #99742 (Add comments about stdout locking)
Document that RawWakerVTable functions must be thread-safe. #100128 (Document that RawWakerVTable functions must be thread-safe.)
Reduce right-side DOM size #100956 (Reduce right-side DOM size)
Fix doc cfg on reexports #101006 (Fix doc cfg on reexports)
rustdoc: remove unused CSS for .variants_table #101012 (rustdoc: remove unused CSS for .variants_table)
rustdoc: remove type="text/css" from stylesheet links #101023 (rustdoc: remove type="text/css" from stylesheet links)
Remove unused build dependency #101031 (Remove unused build dependency)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Also add some intra-doc links and more high-level explanation of how `Waker` is used, while I'm here. Context: https://internals.rust-lang.org/t/thread-safety-of-rawwakervtables/17126

…ements

Continuation of rust-lang#100938 and rust-lang#101010. This rule was added to support the old, table-based style for displaying enum variants, which are now displayed using headers and paragraphs.

MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>, since "CSS is the only stylesheet language used on the web."

BTree: evaluate static type-related check at compile time `assert`s like the ones replaced here would only go off when you run the right test cases, if the code were ever incorrectly changed such that rhey would trigger. But [inspired on a nice forum question](https://users.rust-lang.org/t/compile-time-const-generic-parameter-check/69202), they can be checked at compile time.

Add comments about stdout locking This is the source of some confusion regarding the `println!` macro: * https://llogiq.github.io/2017/06/01/perf-pitfalls.html#unbuffered-io * https://news.ycombinator.com/item?id=18794930 * https://reddit.com/r/rust/comments/5puyx2/why_is_println_so_slow/dcua5g5/ * https://reddit.com/r/rust/comments/ab7hsi/comparing_pythagorean_triples_in_c_d_and_rust/ecy7ql8/ In some of these cases it's not the locking behavior where the bottleneck lies, but it's still mentioned as a surprise when, eg, benchmarking a million `println!`'s in a very tight loop. If there's any stylistic problems please feel free to correct me! This is my first contribution and I want to get it right 🦀

Document that `RawWakerVTable` functions must be thread-safe. Also add some intra-doc links and more high-level explanation of how `Waker` is used, while I'm here. Context: https://internals.rust-lang.org/t/thread-safety-of-rawwakervtables/17126

…m-size, r=notriddle Reduce right-side DOM size This is another follow-up of rust-lang#100429 but not in code blocks this time. So the idea is: if there is only one element in the `.rightside` element, there is no need to wrap it, we can just create one node. On each page, I run this JS: `document.getElementsByTagName('*').length`. Important to note: the bigger the number of elements inside the page, the greater the gain. It also doesn't work very nicely on std docs because there are a lot of version annotations. So with this PR, It allows to get the following results: | file name | before this PR | with this PR | diff | |-|-|-|-| | std/default/trait.Default.html | 2189 | 1331 | 39.2% | | std/vec/struct.Vec.html | 14073 | 13842 | 1.7% | | std/fmt/trait.Debug.html | 5313 | 4907 | 7.7% | | std/ops/trait.Index.html | 642 | 630 | 1.9% | | gtk4/WidgetExt | 3269 | 3061 | 6.4% | You can test it [here](https://rustdoc.crud.net/imperio/reduce-rightsize-dom-size/gtk4/prelude/trait.WidgetExt.html). r? `@notriddle`

…=notriddle Fix doc cfg on reexports Fixes rust-lang#83428. The problem was that the newly inlined item cfg propagation was not working since its real parent is different than its current one. For the implementation, I decided to put it directly into `CfgPropagation` instead of inside `inline.rs` because I thought it would be simpler to maintain and to not forget if new kind of items are added if it's all done in one place. r? `@notriddle`

…, r=jsha rustdoc: remove unused CSS for `.variants_table` Continuation of rust-lang#100938 and rust-lang#101010. This rule was added to support the old, table-based style for displaying enum variants, which are now displayed using headers and paragraphs.

…=Dylan-DPC rustdoc: remove `type="text/css"` from stylesheet links MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>, since "CSS is the only stylesheet language used on the web."

… r=bjorn3 Remove unused build dependency There is no more `build.rs` so this dependency is unused. r? `@Dylan-DPC`

GuillaumeGomez · 2022-08-26T12:09:05Z

@bors r+ rollup=never p=8

bors · 2022-08-26T12:09:07Z

📌 Commit c391ba0 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2022-08-26T13:06:01Z

⌛ Testing commit c391ba0 with merge 42fa8ac...

bors · 2022-08-26T15:47:19Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 42fa8ac to master...

rust-timer · 2022-08-26T15:49:51Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101031	740d23e837d97a7daacd98fde24948c3413fc7f2
#101023	174f5b35cc95be4560a80184558ba32464abaaa7
#101012	36e89b4e10d2d0b015a60aa049a4d25c8357715e
#101006	3765c43334186b1ec37153d443eaa50517ddd4d7
#100956	eaec7f303fdb51de681d61091e04f08f73578aed
#100128	332aa24b8d216779a681da5160e7fe00858c8784
#99742	e6e00c5a6b187f928400c5dfdf03540330af0aaa
#95005	137cc419ac7ec5593920f9d4497fab291fa2d36b

previous master: 8a13871b69

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-26T18:42:12Z

Finished benchmarking commit (42fa8ac): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[0.3%, 3.8%]	3
Regressions ❌ (secondary)	0.9%	[0.5%, 1.2%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.2%]	2
All ❌✅ (primary)	1.5%	[0.3%, 3.8%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.6%, 3.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-3.5%, -1.5%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lqd · 2022-08-26T21:20:19Z

Most likely #101006 since the biggest hit is on libc's doc ? But that looks like a correctness fix anyways.

Let's check: @rust-timer build 3765c43334186b1ec37153d443eaa50517ddd4d7 include=-doc

rust-timer · 2022-08-26T21:20:21Z

Queued 3765c43334186b1ec37153d443eaa50517ddd4d7 with parent 8a13871, future comparison URL.

rust-timer · 2022-08-27T12:30:32Z

Finished benchmarking commit (3765c43334186b1ec37153d443eaa50517ddd4d7): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.6%	[0.4%, 3.8%]	3
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.6%]	6
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	2
All ❌✅ (primary)	0.1%	[-0.8%, 3.8%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[3.8%, 7.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-4.0%, -2.4%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	4.1%	[4.1%, 4.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	0.9%	[-2.3%, 4.1%]	2

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rylev · 2022-08-30T16:01:56Z

@GuillaumeGomez this indeed looks like it's coming from #101006. Given that is a correctness fix, shall we mark this as triaged and move on?

GuillaumeGomez · 2022-08-30T16:03:50Z

yes it's fine and expected.

rylev · 2022-08-30T16:34:29Z

@rustbot label: +perf-regression-triaged

ssomers and others added 22 commits March 16, 2022 13:51

BTree: evaluate static type-related check at compile time

ea4e5c2

Add comments about stdout locking

fab36d1

Document that RawWakerVTable functions must be thread-safe.

1b87306

Also add some intra-doc links and more high-level explanation of how `Waker` is used, while I'm here. Context: https://internals.rust-lang.org/t/thread-safety-of-rawwakervtables/17126

Remove self-referential intra-doc links.

d4bcc4a

Unify rightside rendering

097b382

Remove the extra DOM level if there is only one child in rightside el…

d40a18e

…ements

Update rustdoc tests for simplified rightside DOM

29ac48d

Extend GUI test to check colors for all srclink elements

7220f4a

Add color test for anchors in all themes

38eb33b

Fix missing cfg propagation for reexports

01d64f5

Add test for missing cfg propagation for reexport

2ed9454

rustdoc: remove unused CSS for .variants_table

8c65478

Continuation of rust-lang#100938 and rust-lang#101010. This rule was added to support the old, table-based style for displaying enum variants, which are now displayed using headers and paragraphs.

rustdoc: remove `type="text/css" from stylesheet links

07a243b

MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>, since "CSS is the only stylesheet language used on the web."

Remove unused build dependency

fb33dd8

Rollup merge of rust-lang#101031 - rust-lang:remove-unused-build-dep,…

c391ba0

… r=bjorn3 Remove unused build dependency There is no more `build.rs` so this dependency is unused. r? `@Dylan-DPC`

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 26, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 26, 2022

bors mentioned this pull request Aug 26, 2022

Rollup of 8 pull requests #101026

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2022

bors mentioned this pull request Aug 26, 2022

Reduce right-side DOM size #100956

Merged

bors merged commit 42fa8ac into rust-lang:master Aug 26, 2022

rustbot added this to the 1.65.0 milestone Aug 26, 2022

rustbot added the perf-regression Performance regression. label Aug 26, 2022

GuillaumeGomez deleted the rollup-opn6kj1 branch August 26, 2022 22:01

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2022

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #101037

Rollup of 8 pull requests #101037

GuillaumeGomez commented Aug 26, 2022

GuillaumeGomez commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

rust-timer commented Aug 26, 2022

rust-timer commented Aug 26, 2022

lqd commented Aug 26, 2022

rust-timer commented Aug 26, 2022

rust-timer commented Aug 27, 2022

rylev commented Aug 30, 2022

GuillaumeGomez commented Aug 30, 2022

rylev commented Aug 30, 2022

Rollup of 8 pull requests #101037

Rollup of 8 pull requests #101037

Conversation

GuillaumeGomez commented Aug 26, 2022

GuillaumeGomez commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

rust-timer commented Aug 26, 2022

rust-timer commented Aug 26, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

lqd commented Aug 26, 2022

rust-timer commented Aug 26, 2022

rust-timer commented Aug 27, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

rylev commented Aug 30, 2022

GuillaumeGomez commented Aug 30, 2022

rylev commented Aug 30, 2022