Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make char::is_lowercase and char::is_uppercase const #101401

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Make char::is_lowercase and char::is_uppercase const #101401

merged 2 commits into from
Sep 4, 2022

Conversation

mx00s
Copy link
Contributor

@mx00s mx00s commented Sep 4, 2022

Implements #101400.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 4, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022
@mx00s mx00s mentioned this pull request Sep 4, 2022
Closed
3 tasks
fee1-dead
fee1-dead approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than to make the types of constants &'static [T; N] instead of arrays to prevent copying.

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2022

Error: Label const-hack can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@mx00s
Copy link
Contributor Author

mx00s commented Sep 4, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 4, 2022
@mx00s
Copy link
Contributor Author

mx00s commented Sep 4, 2022

LGTM other than to make the types of constants &'static [T; N] instead of arrays to prevent copying.

Thank you for the helpful feedback and positive review, @fee1-dead.

I'm a new contributor, so I have a procedural question. Now that I've made the requested changes will you (or someone else) also have to tell bors r+ or will your GitHub approval be sufficient?

@fee1-dead
Copy link
Member

fee1-dead commented Sep 4, 2022 •
edited
Loading

Looks good to me, thanks for the PR. An r+ is needed to merge. The GitHub approval is not used for this purpose.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 4, 2022

📌 Commit 2b328ea has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 4, 2022
@bors
Auto merge of rust-lang#101411 - matthiaskrgr:rollup-uj24yb5, r=matth…
0ebd3ab 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101322 (Fix internal doc link)
 - rust-lang#101385 (updated description of File struct in std::fs)
 - rust-lang#101388 (Don't delay invalid LHS bug unless it will be covered by an error in `check_overloaded_binop`)
 - rust-lang#101394 (Forbid mixing `System` with direct sytem allocator calls)
 - rust-lang#101397 (rustdoc: remove redundant mobile-sized `.source nav:not(.sidebar).sub`)
 - rust-lang#101401 (Make `char::is_lowercase` and `char::is_uppercase` const)
 - rust-lang#101407 (Remove duplicated test (superseeded by search-form-elements.goml))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d9bba11 into rust-lang:master Sep 4, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 4, 2022
@mx00s mx00s deleted the expand-const branch September 4, 2022 22:19
@fee1-dead fee1-dead mentioned this pull request Sep 12, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101724 - fee1-dead-contrib:triage-const-hac…
c75f513 
…k, r=oli-obk

Allow unauthenticated users to add the `const-hack` label

Observed in rust-lang#101401.

cc `@oli-obk`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101724 - fee1-dead-contrib:triage-const-hac…
86faf6c 
…k, r=oli-obk

Allow unauthenticated users to add the `const-hack` label

Observed in rust-lang#101401.

cc ``@oli-obk``
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101724 - fee1-dead-contrib:triage-const-hac…
bbe23e8 
…k, r=oli-obk

Allow unauthenticated users to add the `const-hack` label

Observed in rust-lang#101401.

cc ```@oli-obk```
@RalfJung RalfJung mentioned this pull request Oct 13, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 13, 2024
@matthiaskrgr
Rollup merge of rust-lang#131641 - RalfJung:unicode-bitset-static, r=…
84dd8cd 
…dtolnay

switch unicode-data bitsets back to 'static'

Back in rust-lang#101401, these were changed to `const` to make some functions `const fn`. However, `@dtolnay` was [not happy](rust-lang#101400 (comment)) about this. Meanwhile, `const fn` can access immutable statics like these, so we can change this back.

Part of rust-lang#101400.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@rust-timer
Unrolled build for rust-lang#131641
c7f2c12 
Rollup merge of rust-lang#131641 - RalfJung:unicode-bitset-static, r=dtolnay

switch unicode-data bitsets back to 'static'

Back in rust-lang#101401, these were changed to `const` to make some functions `const fn`. However, `@dtolnay` was [not happy](rust-lang#101400 (comment)) about this. Meanwhile, `const fn` can access immutable statics like these, so we can change this back.

Part of rust-lang#101400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faptc faptc faptc left review comments

@klensy klensy klensy left review comments

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
8 participants
@mx00s @rust-highfive @rustbot @fee1-dead @bors @klensy @faptc @Mark-Simulacrum