-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up maybe_uninit_as_bytes API #103128
Conversation
- Follow mut naming conversion - Move types to extensions Signed-off-by: Alex Saveau <[email protected]>
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
(rust-highfive has picked a reviewer for you, use r? to override) |
Thanks for the PR! While I'm sometimes willing to add new APIs without libs-api assent, I'm much more worried about churning signatures without contacting them to see if they like them, since it would be a shame to find out they didn't and have to revert it and have impacted nightly users unnecessarily. Could you please file an ACP for this set of changes (I think #103128 #103130 #103131 could probably all be one) to get a "yup, that seems better" from the team? @rustbot author |
Sounds good! Created rust-lang/libs-team#123 |
Gonna nuke these methods, see rust-lang/libs-team#122 (comment) |
The diff is super weird because it misunderstood what was moved.