Clean up hidden type registration #103255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
| @@ -395,12 +394,10 @@ where | |||
|
|
|||
| fn relate_opaques(&mut self, a: Ty<'tcx>, b: Ty<'tcx>) -> RelateResult<'tcx, Ty<'tcx>> { | |||
| let (a, b) = if self.a_is_expected() { (a, b) } else { (b, a) }; | |||
| let cause = self.delegate.cause().clone(); | |||
There was a problem hiding this comment.
why is this clone needed?
There was a problem hiding this comment.
Ah that's just noise fromthe attempt to pass down the relation itself.
|
@bors r+ |
|
📌 Commit f4da3d4db6e3aa4b0367913734afec5d4c35807d has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
@bors r- need to remove some clones |
bors
added
S-waiting-on-author
oli-obk
force-pushed
the
opaque_wrong_eq_relation
branch
from
f4da3d4 to
de5517c
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#103110 (remove redundant Send impl for references) - rust-lang#103255 (Clean up hidden type registration) - rust-lang#103394 (Clarify documentation about the memory layout of `UnsafeCell`) - rust-lang#103408 (Clean return-position `impl Trait` in traits correctly in rustdoc) - rust-lang#103505 (rustdoc: parse self-closing tags and attributes in `invalid_html_tags`) - rust-lang#103524 (rustc_metadata: Add struct and variant constructors to module children at encoding time) - rust-lang#103544 (Add flag to forbid recovery in the parser) - rust-lang#103616 (rustdoc: remove CSS workaround for Firefox 29) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work on #101186
Actually passing down the relation and using it instead of
eqfor the hidden type comparison has no effect whatsoever and allows for no further improvements at the call sites. I decided the increased complexity was not worth it and thus did not include that change in this PR.r? @compiler-errors