Loosen `From<&[T]> for Box<[T]>` bound to `T: Clone` #103406

Jules-Bertholet · 2022-10-22T16:37:16Z

Also loosens From<Cow<'_, [T]>> for Box<[T]>'s bound.

rustbot · 2022-10-22T16:37:20Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-10-22T16:37:20Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

Jules-Bertholet · 2022-10-22T16:37:35Z

@rustbot label +T-libs-api -T-libs

thomcc · 2022-10-22T18:03:47Z

Needs FCP.

r? @m-ou-se

m-ou-se · 2022-12-30T13:07:47Z

@rfcbot merge

rfcbot · 2022-12-30T13:07:48Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2023-01-07T22:02:48Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-01-17T22:04:55Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

dtolnay

stack-protector-heuristics-effect test is failing in CI. Presumably in relation with this From<&[T]> for Box<[T]> usage:

https://github.com/rust-lang/rust/blob/b0f2d6f23fbf847ee1c12d55ab7a3f96561bfd94/src/test/assembly/stack-protector/stack-protector-heuristics-effect.rs#L362

https://github.com/rust-lang/rust/blob/b0f2d6f23fbf847ee1c12d55ab7a3f96561bfd94/src/test/assembly/stack-protector/stack-protector-heuristics-effect.rs#L383

jyn514 · 2023-04-27T02:55:54Z

Hi @Jules-Bertholet, it's been a while - are you still planning to work on this? Do you know how to make progress? Feel free to ask for help here or on Zulip if you get stuck.

Jules-Bertholet · 2023-04-27T04:18:27Z

@rustbot ready

jyn514

This looks good to me but it should probably have a T-libs reviewer, especially to double-check the specialization.

library/alloc/src/boxed.rs

Co-authored-by: David Tolnay <[email protected]>

dtolnay

Thanks!

dtolnay · 2023-04-29T22:12:11Z

@bors r+

bors · 2023-04-29T22:12:13Z

📌 Commit 18d2c60 has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-04-30T13:58:03Z

⌛ Testing commit 18d2c60 with merge 831c929...

…o_box, r=dtolnay Loosen `From<&[T]> for Box<[T]>` bound to `T: Clone` Also loosens `From<Cow<'_, [T]>> for Box<[T]>`'s bound. [Discussion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/From.3C.26.5BT.5D.3E.20impls.20consistency)

bors · 2023-04-30T16:54:08Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 831c929 to master...

rust-timer · 2023-04-30T18:27:51Z

Finished benchmarking commit (831c929): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.5%, 2.0%]	2
Regressions ❌ (secondary)	6.1%	[6.1%, 6.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.5%, 2.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

rust-highfive assigned thomcc Oct 22, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 22, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 22, 2022

thomcc added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Oct 22, 2022

rust-highfive assigned m-ou-se and unassigned thomcc Oct 22, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 30, 2022

m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 7, 2023

dtolnay assigned dtolnay and unassigned m-ou-se Jan 17, 2023

dtolnay requested changes Jan 17, 2023

View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Jan 17, 2023

apiraino removed the to-announce Announce this issue on triage meeting label Jan 19, 2023

Loosen From<&[T]> for Box<[T]> bound to T: Clone

075ee26

Jules-Bertholet force-pushed the from_clone_slice_to_box branch from b0f2d6f to 075ee26 Compare April 27, 2023 03:41

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2023

jyn514 approved these changes Apr 27, 2023

View reviewed changes

dtolnay reviewed Apr 29, 2023

View reviewed changes

library/alloc/src/boxed.rs Show resolved Hide resolved

cfg-gate BoxFromSlice trait

18d2c60

Co-authored-by: David Tolnay <[email protected]>

dtolnay approved these changes Apr 29, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2023

Dylan-DPC mentioned this pull request Apr 30, 2023

Rollup of 6 pull requests #111019

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 30, 2023

bors merged commit 831c929 into rust-lang:master Apr 30, 2023

rustbot added this to the 1.71.0 milestone Apr 30, 2023

Jules-Bertholet deleted the from_clone_slice_to_box branch April 30, 2023 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Loosen `From<&[T]> for Box<[T]>` bound to `T: Clone` #103406

Loosen `From<&[T]> for Box<[T]>` bound to `T: Clone` #103406

Jules-Bertholet commented Oct 22, 2022

rustbot commented Oct 22, 2022

rust-highfive commented Oct 22, 2022

Jules-Bertholet commented Oct 22, 2022

thomcc commented Oct 22, 2022

m-ou-se commented Dec 30, 2022

rfcbot commented Dec 30, 2022 •

edited by dtolnay

Loading

rfcbot commented Jan 7, 2023

rfcbot commented Jan 17, 2023

dtolnay left a comment

jyn514 commented Apr 27, 2023

Jules-Bertholet commented Apr 27, 2023

jyn514 left a comment

dtolnay left a comment

dtolnay commented Apr 29, 2023

bors commented Apr 29, 2023

bors commented Apr 30, 2023

bors commented Apr 30, 2023

rust-timer commented Apr 30, 2023

Loosen From<&[T]> for Box<[T]> bound to T: Clone #103406

Loosen From<&[T]> for Box<[T]> bound to T: Clone #103406

Conversation

Jules-Bertholet commented Oct 22, 2022

rustbot commented Oct 22, 2022

rust-highfive commented Oct 22, 2022

Jules-Bertholet commented Oct 22, 2022

thomcc commented Oct 22, 2022

m-ou-se commented Dec 30, 2022

rfcbot commented Dec 30, 2022 • edited by dtolnay Loading

rfcbot commented Jan 7, 2023

rfcbot commented Jan 17, 2023

dtolnay left a comment

Choose a reason for hiding this comment

jyn514 commented Apr 27, 2023

Jules-Bertholet commented Apr 27, 2023

jyn514 left a comment

Choose a reason for hiding this comment

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented Apr 29, 2023

bors commented Apr 29, 2023

bors commented Apr 30, 2023

bors commented Apr 30, 2023

rust-timer commented Apr 30, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Loosen `From<&[T]> for Box<[T]>` bound to `T: Clone` #103406

Loosen `From<&[T]> for Box<[T]>` bound to `T: Clone` #103406

rfcbot commented Dec 30, 2022 •

edited by dtolnay

Loading