Lang item cleanups #103603
Merged
Lang item cleanups #103603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
camsteffen
force-pushed
the
refactor-lang
branch
from
35b2b81 to
79d5cc4
Compare
oli-obk
requested changes
Oct 28, 2022
bjorn3
reviewed
Oct 28, 2022
camsteffen
force-pushed
the
refactor-lang
branch
from
79d5cc4 to
e4eb7ae
Compare
camsteffen
force-pushed
the
refactor-lang
branch
from
e4eb7ae to
1c8e658
Compare
rustbot
added
the
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
I just removed a diagnostic struct in favor of |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#103338 (Fix unreachable_pub suggestion for enum with fields) - rust-lang#103603 (Lang item cleanups) - rust-lang#103732 (Revert "Make the `c` feature for `compiler-builtins` opt-in instead of inferred") - rust-lang#103766 (Add tracking issue to `error_in_core`) - rust-lang#103789 (Update E0382.md) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Nov 5, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 18, 2022
Add variant_name function to `LangItem` Clippy has an internal lint that checks for the usage of hardcoded def paths and suggests to replace them with a lang or diagnostic item, if possible. This was implemented with a hack, by getting all the variants of the `LangItem` enum and then index into it with the position of the `LangItem` in the `items` list. This is no longer possible, because the `items` list can't be accessed anymore. Follow up to rust-lang#103603 cc `@camsteffen` r? `@oli-obk` This is blocking the sync between Clippy and Rust. I'm not sure if this is the best solution here, or if I should add a method `items()` to `LanguageItems` and keep the code in Clippy unchanged.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
Add variant_name function to `LangItem` Clippy has an internal lint that checks for the usage of hardcoded def paths and suggests to replace them with a lang or diagnostic item, if possible. This was implemented with a hack, by getting all the variants of the `LangItem` enum and then index into it with the position of the `LangItem` in the `items` list. This is no longer possible, because the `items` list can't be accessed anymore. Follow up to rust-lang#103603 cc `@camsteffen` r? `@oli-obk` This is blocking the sync between Clippy and Rust. I'm not sure if this is the best solution here, or if I should add a method `items()` to `LanguageItems` and keep the code in Clippy unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups related to lang items.