Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way libunwind is linked for *-windows-gnullvm targets #103894

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Change the way libunwind is linked for *-windows-gnullvm targets #103894

merged 3 commits into from
Nov 14, 2022

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Nov 2, 2022

I have no idea why previous way works for x86_64-fortanix-unknown-sgx (assuming it actually works...) but not for gnullvm. It fails when linking libtest during Rust build (unless somebody adds RUSTFLAGS='-Clinkarg=-lunwind').
Also fixes exception handling on AArch64.

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 2, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@mati865 mati865 force-pushed the gnullvm-libunwind-changes branch from abfd414 to 6507460 Compare November 12, 2022 11:18
@mati865 mati865 force-pushed the gnullvm-libunwind-changes branch from 6507460 to 7333ee0 Compare November 12, 2022 11:19
@thomcc
Copy link
Member

thomcc commented Nov 13, 2022

This looks fine to me.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 13, 2022

📌 Commit 7333ee0 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2022
@bors
Copy link
Contributor

bors commented Nov 13, 2022

⌛ Testing commit 7333ee0 with merge 7b513af...

@bors
Copy link
Contributor

bors commented Nov 14, 2022

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 7b513af to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 14, 2022
@bors bors merged commit 7b513af into rust-lang:master Nov 14, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 14, 2022
@bors bors mentioned this pull request Nov 14, 2022
Merged
@mati865 mati865 deleted the gnullvm-libunwind-changes branch November 14, 2022 00:54
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7b513af): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.6% [-5.6%, -3.6%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.2% [-4.2%, -4.2%] 1
All ❌✅ (primary) - - 0

@mati865 mati865 mentioned this pull request Nov 15, 2022
Merged
mati865 added a commit to mati865/rust that referenced this pull request Nov 15, 2022
@mati865
Reduce exceptions overallocation on non Windows x86_64
10d0f14 
Addressing rust-lang#103894 (comment)
@mati865 mati865 mentioned this pull request Nov 15, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#104461 - mati865:gnullvm-aarch64-fixup, r=M…
6a722aa 
…ark-Simulacrum

Fix building of `aarch64-pc-windows-gnullvm`

That change had been lost during rebase of my last PR (rust-lang#103894).
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Nov 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#104464 - mati865:reduce-eh-overallocation-a…
20d6a44 
…md64, r=thomcc

Reduce exceptions overallocation on non Windows x86_64

Addressing rust-lang#103894 (comment)
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103894 - mati865:gnullvm-libunwind-changes, r…
f0f922c 
…=thomcc

Change the way libunwind is linked for *-windows-gnullvm targets

I have no idea why previous way works for `x86_64-fortanix-unknown-sgx` (assuming it actually works...) but not for `gnullvm`. It fails when linking libtest during Rust build (unless somebody adds `RUSTFLAGS='-Clinkarg=-lunwind'`).
Also fixes exception handling on AArch64.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@mati865
Reduce exceptions overallocation on non Windows x86_64
e685b67 
Addressing rust-lang/rust#103894 (comment)
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@matthiaskrgr
Rollup merge of #104461 - mati865:gnullvm-aarch64-fixup, r=Mark-Simul…
60ea177 
…acrum

Fix building of `aarch64-pc-windows-gnullvm`

That change had been lost during rebase of my last PR (rust-lang/rust#103894).
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@Dylan-DPC
Rollup merge of #104464 - mati865:reduce-eh-overallocation-amd64, r=t…
40ab083 
…homcc

Reduce exceptions overallocation on non Windows x86_64

Addressing rust-lang/rust#103894 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc left review comments

Assignees

@thomcc thomcc

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mati865 @rustbot @thomcc @bors @rust-timer