Deny global_asm in deny(unsafe_code) #103918

gimbling-away · 2022-11-03T09:51:37Z

Fixes #103078

rustbot · 2022-11-03T09:51:48Z

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

Noratrieb · 2022-11-03T10:29:40Z

You have your test binary checked in

fee1-dead

Please add a ui test, also please squash the commit so that the binary does not appear in the history.

gimbling-away · 2022-11-03T15:40:28Z

Done 👏🏻

fee1-dead · 2022-11-03T15:44:36Z

compiler/rustc_middle/src/lint.rs

+            if id.as_str() == "core::arch::global_asm" {
+                return false;
+            }


Please add a comment explaining that this is needed such that the unsafe_code lint works correctly.

Also, what if an external macro generates global_asm? Would that be denied by the compiler?

This option prints all supported values for -Csplit-debuginfo=.., i.e. only stable ones on stable/beta and all of them on nightly/dev.

fix: lint against the functions `LintContext::{lookup_with_diagnostics,lookup,struct_span_lint,lint}`, `TyCtxt::struct_lint_node`, `LintLevelsBuilder::struct_lint`.

Co-authored-by: clubby789 <[email protected]>

…RTB error from generator interior

… extend test

Fixes #102576

rustbot · 2022-11-12T09:35:44Z

rustc_errors::translation was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

Some changes occurred in src/tools/cargo

cc @ehuss

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

A change occurred in the Ayu theme.

cc @Cldfire

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

gimbling-away · 2022-11-12T09:45:28Z

OH NO

gimbling-away · 2022-11-12T09:47:36Z

I messed up a rebase I seriously didn't mean to ping everyone 😓

rustbot assigned fee1-dead Nov 3, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2022

This comment has been minimized.

Sign in to view

fee1-dead requested changes Nov 3, 2022

View reviewed changes

fee1-dead reviewed Nov 3, 2022

View reviewed changes

fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2022

chenyukang and others added 19 commits November 12, 2022 15:04

code cleanup with err.emit_unless

43bf732

Place config.toml in current working directory if config not found

4c512af

Only set config.config to None when using default path

c54bc07

disable btree size tests on Miri

f6c04da

run alloc benchmarks in Miri and fix UB

ce06c8e

fmt

e614206

Add --print=split-debuginfo

02a866a

This option prints all supported values for -Csplit-debuginfo=.., i.e. only stable ones on stable/beta and all of them on nightly/dev.

rustdoc: Add mutable to the description

503d625

Fix const_fn_trait_ref_impl, add test for it

f86e5de

Reworked const fn ref tests

ff61d6c

Fix invalid background-image file name

2e3cfbb

fix: lint against lint functions

2410684

fix: lint against the functions `LintContext::{lookup_with_diagnostics,lookup,struct_span_lint,lint}`, `TyCtxt::struct_lint_node`, `LintLevelsBuilder::struct_lint`.

clarify licensing situation of mpsc and spsc queue

4c41db5

Remove an address comparison from the parser

4c671cc

Fix outdated comment

342aee2

Co-authored-by: clubby789 <[email protected]>

Add llvm-main to triagebot.toml

347956b

Add an optional Span to BrAnon and use it to print better error for H…

1f15e8b

…RTB error from generator interior

Get spans for a couple more region types, add some optimizations, and…

a198591

… extend test

Add a known that this is a known limitation

efbab67

RalfJung and others added 26 commits November 12, 2022 15:05

merge rustup-toolchain into ./miri

b3c8584

Stacked Borrows: make scalar field retagging the default

31160c4

rustup

b18fe3d

fix dupe word typos

d42bad5

followup for pr 2640

34eebdb

fix ./miri bench

37107e5

add acquire when init once is already complete

f2af03b

refactor into private functions

b7c2858

clarify no_data_race_after_complete test

f1e6fe3

impl condvars for windows

39e5ce7

use enum for condvar locks

4d1fee8

fix shared behavior and add tests

460e90c

rustdoc: refactor notable_traits_decl to just act on the type directly

327d2e1

rustdoc: use javascript to layout notable traits popups

da9d28f

Fixes #102576

rustdoc: fix font color inheritance from body, and test

19e1c7b

rustdoc: sort output to make it deterministic

cef1ac3

rustdoc: fix HTML validation failure by escaping data-ty

ccbdd81

std: remove lock wrappers in sys_common

8915da9

std: fix double-free of mutex

db9fa27

update LLVM submodule to make libunwind work on SGX

2d8b250

update debuginfo check

ff19acb

Tweak signatures in rustc_middle::hir::map.

8cf5ebb

Resolve lifetimes independently for each item-like.

83972eb

Resolve lifetimes using the regular logic for RPIT.

f43591b

Visit opaque types during type collection too.

122d167

Clean-up formatting.

8683326

gimbling-away closed this Nov 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deny global_asm in deny(unsafe_code) #103918

Deny global_asm in deny(unsafe_code) #103918

gimbling-away commented Nov 3, 2022

rustbot commented Nov 3, 2022

This comment has been minimized.

Noratrieb commented Nov 3, 2022

fee1-dead left a comment

gimbling-away commented Nov 3, 2022

fee1-dead Nov 3, 2022

rustbot commented Nov 12, 2022

gimbling-away commented Nov 12, 2022

gimbling-away commented Nov 12, 2022

Deny global_asm in deny(unsafe_code) #103918

Deny global_asm in deny(unsafe_code) #103918

Conversation

gimbling-away commented Nov 3, 2022

rustbot commented Nov 3, 2022

This comment has been minimized.

Noratrieb commented Nov 3, 2022

fee1-dead left a comment

Choose a reason for hiding this comment

gimbling-away commented Nov 3, 2022

fee1-dead Nov 3, 2022

Choose a reason for hiding this comment

rustbot commented Nov 12, 2022

gimbling-away commented Nov 12, 2022

gimbling-away commented Nov 12, 2022