Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a reference to ilog2 in leading_zeros integer docs #104263

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Add a reference to ilog2 in leading_zeros integer docs #104263

merged 3 commits into from
Nov 12, 2022

Conversation

albertlarsan68
Copy link
Member

Fixes #104248

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2022

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@albertlarsan68 albertlarsan68 force-pushed the add-ilog2-to-leading-zeroes-docs branch 2 times, most recently from dce35ef to 38f2f1e Compare November 10, 2022 23:11
@albertlarsan68
Copy link
Member Author

@rustbot label +A-docs

@rustbot rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Nov 10, 2022
@albertlarsan68 albertlarsan68 force-pushed the add-ilog2-to-leading-zeroes-docs branch from 38f2f1e to d85b614 Compare November 10, 2022 23:56
@rust-log-analyzer

This comment has been minimized.

Sign in to view
scottmcm
scottmcm reviewed Nov 11, 2022
View reviewed changes
src/etc/pre-push.sh Outdated Show resolved Hide resolved
@scottmcm scottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022
@albertlarsan68
Copy link
Member Author

CI passes, I hope the links are correct.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2022
@scottmcm
Copy link
Member

Thanks! If CI's happy hopefully that means that link's correct -- the macros definitely complicate things here.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2022

📌 Commit a1909b7 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2022
@albertlarsan68
Copy link
Member Author

I took example on another doc comment in the same macros, which uses the "reference links" feature.

@albertlarsan68
Copy link
Member Author

Can this PR be rolled up ?

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104263 - albertlarsan68:add-ilog2-to-leadin…
338ca5c 
…g-zeroes-docs, r=scottmcm

Add a reference to ilog2 in leading_zeros integer docs

Fixes rust-lang#104248
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 12, 2022
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2022
@bors
Auto merge of rust-lang#104325 - GuillaumeGomez:rollup-19bzwoa, r=Gui…
cd12888 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types)
 - rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.)
 - rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal)
 - rust-lang#104250 (Migrate no result page link color to CSS variables)
 - rust-lang#104261 (More accurately report error when formal and expected signature types differ)
 - rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs)
 - rust-lang#104308 (Remove the old `ValidAlign` name)
 - rust-lang#104319 (Fix non clickable source link)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cd4b3ac into rust-lang:master Nov 12, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 12, 2022
@albertlarsan68 albertlarsan68 deleted the add-ilog2-to-leading-zeroes-docs branch November 12, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmcm scottmcm scottmcm left review comments

Assignees

@scottmcm scottmcm

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Mention ilog2 from leading_zeros docs
5 participants
@albertlarsan68 @rustbot @rust-log-analyzer @scottmcm @bors