Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix std::thread docs are unclear regarding stack sizes #104537

Merged
merged 1 commit into from
Nov 20, 2022
Merged

fix std::thread docs are unclear regarding stack sizes #104537

merged 1 commit into from
Nov 20, 2022

Conversation

HintringerFabian
Copy link
Contributor

@HintringerFabian HintringerFabian commented Nov 17, 2022 •
edited by the8472
Loading

Improves the documentation about the default stack size of a spawned thread
Fixes #102671

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 17, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@HintringerFabian HintringerFabian changed the title Improve documentation of Stack size std::thread docs are unclear regarding stack sizes Nov 17, 2022
@HintringerFabian HintringerFabian changed the title std::thread docs are unclear regarding stack sizes fix std::thread docs are unclear regarding stack sizes Nov 17, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@HintringerFabian HintringerFabian force-pushed the docs_default_min_stack_size branch from b3721fc to 0f93846 Compare November 20, 2022 08:58
@the8472
Copy link
Member

the8472 commented Nov 20, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 20, 2022

📌 Commit 0f93846 has been approved by the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2022
@bors
Auto merge of rust-lang#104646 - matthiaskrgr:rollup-7xnhzf0, r=matth…
a28f3c8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#104537 (fix std::thread docs are unclear regarding stack sizes)
 - rust-lang#104558 (Don't assume `FILE_ID_BOTH_DIR_INFO` will be aligned)
 - rust-lang#104564 (interpret: use Either over Result when it is not representing an error condition)
 - rust-lang#104568 (clarify that realloc refreshes pointer provenance even when the allocation remains in-place)
 - rust-lang#104611 (rustdoc: use real buttons for scrape examples controls)
 - rust-lang#104640 (Migrate kdb style to CSS variables)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ddb1234 into rust-lang:master Nov 20, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 20, 2022
@HintringerFabian HintringerFabian deleted the docs_default_min_stack_size branch November 21, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

std::thread docs are unclear regarding stack sizes
6 participants
@HintringerFabian @rustbot @rust-log-analyzer @the8472 @bors @m-ou-se