Switch `#[track_caller]` back to a no-op unless feature gate is enabled #104741

bryangarza · 2022-11-22T21:26:28Z

This patch fixes a regression, in which #[track_caller], which was previously a no-op, was changed to actually turn on the behavior. This should instead only happen behind the closure_track_caller feature gate.

Also, add a warning for the user to understand how their code will compile depending on the feature gate being turned on or not.

Fixes #104588

rustbot · 2022-11-22T21:26:36Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2022-11-22T21:26:39Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

bryangarza · 2022-11-22T21:26:57Z

r? @compiler-errors

src/test/ui/async-await/track-caller/issue-104588-no-op-track-caller.stderr

compiler/rustc_lint/src/builtin.rs

compiler-errors

Thanks for the PR. I had some questions, though I may be missing some context, so feel free to correct me if I assumed something incorrectly.

compiler/rustc_ast_lowering/src/expr.rs

compiler/rustc_error_messages/locales/en-US/lint.ftl

compiler/rustc_lint/src/builtin.rs

src/test/ui/async-await/track-caller/issue-104588-no-op-panic-track-caller.rs

bryangarza · 2022-11-24T03:51:21Z

I addressed most of the comments and resolved their threads, but there's a couple more I have to follow up with in another commit :)

bryangarza · 2022-11-24T04:00:09Z

TODO: add a doc comment to the lint definition

bors · 2022-12-02T19:10:03Z

☔ The latest upstream changes (presumably #104863) made this pull request unmergeable. Please resolve the merge conflicts.

bryangarza · 2022-12-06T04:51:04Z

My latest commit is near-identical to #105180 so I think I will need to just remove that one and rebase (there might be a couple lines to keep from the commit, but not related to the hirId)

bryangarza · 2022-12-07T20:50:27Z

@rustbot ready

compiler/rustc_ast_lowering/src/expr.rs

compiler/rustc_lint/src/builtin.rs

bryangarza · 2022-12-13T05:28:10Z

Thanks for the comments! I’ll update this PR soon

bors · 2022-12-14T02:01:26Z

☔ The latest upstream changes (presumably #105667) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2022-12-22T02:25:27Z

@bors r+ rollup

bors · 2022-12-22T02:25:29Z

📌 Commit ccbba0a has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2022-12-22T02:27:44Z

Beta nominating this because this fixes a regression that's currently stable-to-beta (introduced in #104219) where #[track_caller] on async fn turned from a no-op to a hard error. This instead emits a warning in that case for future compatibility reasons, but still allows the code to compile with the track_caller as a no-op.

…caller, r=compiler-errors Switch `#[track_caller]` back to a no-op unless feature gate is enabled This patch fixes a regression, in which `#[track_caller]`, which was previously a no-op, was changed to actually turn on the behavior. This should instead only happen behind the `closure_track_caller` feature gate. Also, add a warning for the user to understand how their code will compile depending on the feature gate being turned on or not. Fixes rust-lang#104588

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#104741 (Switch `#[track_caller]` back to a no-op unless feature gate is enabled) - rust-lang#105769 (add function to tell the identical errors for ambiguity_errors) - rust-lang#105843 (Suggest associated const on possible capitalization mistake) - rust-lang#105966 (Re-enable `Fn` trait call notation error for non-tuple argument) - rust-lang#106002 (codegen tests: adapt patterns to also work with v0 symbol mangling) - rust-lang#106010 (Give opaque types a better coherence error) - rust-lang#106016 (rustdoc: simplify link anchor to section expand JS) - rust-lang#106024 (Fix ICE due to `todo!()` in `rustdoc` for `Term`s) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

apiraino · 2022-12-22T15:12:49Z

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

Mark-Simulacrum · 2022-12-26T22:36:41Z

This PR does not backport cleanly -- @bryangarza would you be able to prepare a PR targeting the beta branch?

bryangarza · 2022-12-27T16:45:50Z

Sounds good, I'll create the backport PR

…ller_beta-backport, r=compiler-errors Backport: Switch `#[track_caller]` back to a no-op unless feature gate is enabled Backport of rust-lang#104741 r? `@compiler-errors` since you reviewed the original PR requested by `@Mark-Simulacrum` rust-lang#104741 (comment)

rustbot assigned jackh726 Nov 22, 2022

rustbot assigned compiler-errors and unassigned jackh726 Nov 22, 2022

bryangarza force-pushed the bug-104588-async-track-caller branch 2 times, most recently from 7d748cd to e589c06 Compare November 22, 2022 21:43

bryangarza commented Nov 22, 2022

View reviewed changes

src/test/ui/async-await/track-caller/issue-104588-no-op-track-caller.stderr Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

compiler-errors reviewed Nov 22, 2022

View reviewed changes

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

compiler-errors requested changes Nov 22, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2022

bryangarza force-pushed the bug-104588-async-track-caller branch from 882873a to 38f8561 Compare December 7, 2022 20:13

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2022

bryangarza requested a review from compiler-errors December 7, 2022 20:52

compiler-errors reviewed Dec 13, 2022

View reviewed changes

compiler/rustc_ast_lowering/src/expr.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 21, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2022

compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 22, 2022

matthiaskrgr mentioned this pull request Dec 22, 2022

Rollup of 8 pull requests #106031

Closed

matthiaskrgr mentioned this pull request Dec 22, 2022

Rollup of 8 pull requests #106034

Merged

bors merged commit 0adf9e0 into rust-lang:master Dec 22, 2022

rustbot added this to the 1.68.0 milestone Dec 22, 2022

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 22, 2022

bryangarza deleted the bug-104588-async-track-caller branch December 22, 2022 22:22

bryangarza restored the bug-104588-async-track-caller branch December 27, 2022 17:20

bryangarza mentioned this pull request Dec 27, 2022

Backport: Switch #[track_caller] back to a no-op unless feature gate is enabled #106188

Merged

Mark-Simulacrum modified the milestones: 1.68.0, 1.67.0 Dec 27, 2022

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 27, 2022

bryangarza deleted the bug-104588-async-track-caller branch December 28, 2022 03:21

tmandry mentioned this pull request Mar 28, 2023

Tracking Issue for #[track_caller] on closures #87417

Open

3 tasks

bryangarza mentioned this pull request Apr 6, 2023

Tracking Issue for #[track_caller] on async fn #110011

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch `#[track_caller]` back to a no-op unless feature gate is enabled #104741

Switch `#[track_caller]` back to a no-op unless feature gate is enabled #104741

bryangarza commented Nov 22, 2022

rustbot commented Nov 22, 2022

rustbot commented Nov 22, 2022

bryangarza commented Nov 22, 2022

This comment has been minimized.

compiler-errors left a comment •

edited

Loading

bryangarza commented Nov 24, 2022 •

edited

Loading

bryangarza commented Nov 24, 2022 •

edited

Loading

This comment has been minimized.

bors commented Dec 2, 2022

bryangarza commented Dec 6, 2022

bryangarza commented Dec 7, 2022

bryangarza commented Dec 13, 2022 •

edited

Loading

bors commented Dec 14, 2022

compiler-errors commented Dec 22, 2022

bors commented Dec 22, 2022

compiler-errors commented Dec 22, 2022 •

edited

Loading

apiraino commented Dec 22, 2022

Mark-Simulacrum commented Dec 26, 2022

bryangarza commented Dec 27, 2022

Switch #[track_caller] back to a no-op unless feature gate is enabled #104741

Switch #[track_caller] back to a no-op unless feature gate is enabled #104741

Conversation

bryangarza commented Nov 22, 2022

rustbot commented Nov 22, 2022

rustbot commented Nov 22, 2022

bryangarza commented Nov 22, 2022

This comment has been minimized.

compiler-errors left a comment • edited Loading

Choose a reason for hiding this comment

bryangarza commented Nov 24, 2022 • edited Loading

bryangarza commented Nov 24, 2022 • edited Loading

This comment has been minimized.

bors commented Dec 2, 2022

bryangarza commented Dec 6, 2022

bryangarza commented Dec 7, 2022

bryangarza commented Dec 13, 2022 • edited Loading

bors commented Dec 14, 2022

compiler-errors commented Dec 22, 2022

bors commented Dec 22, 2022

compiler-errors commented Dec 22, 2022 • edited Loading

apiraino commented Dec 22, 2022

Mark-Simulacrum commented Dec 26, 2022

bryangarza commented Dec 27, 2022

Switch `#[track_caller]` back to a no-op unless feature gate is enabled #104741

Switch `#[track_caller]` back to a no-op unless feature gate is enabled #104741

compiler-errors left a comment •

edited

Loading

bryangarza commented Nov 24, 2022 •

edited

Loading

bryangarza commented Nov 24, 2022 •

edited

Loading

bryangarza commented Dec 13, 2022 •

edited

Loading

compiler-errors commented Dec 22, 2022 •

edited

Loading